<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113499/">http://git.reviewboard.kde.org/r/113499/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 9d47a8e79be3d06df8c7a914922e942fa68cc25a by José Manuel Santamaría Lema to branch KDE/4.11.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On October 29th, 2013, 5:17 p.m. UTC, José Manuel Santamaría Lema wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By José Manuel Santamaría Lema.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2013, 5:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=214263">214263</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, since some time ago the plugins based on mediawiki doesn't work. I tend to think this happens because of a bug in the embedded copy of mwclient, so I have just updated it to the latest version and now the plugins to acquire images and sounds work. In addition to copy the files, I also had to update the file plugins/wiktionary/CMakeLists.txt in order to get some new files from mwclient installed.
Caveat: if you are going to test the patch you may hit this other bug: https://bugs.kde.org/show_bug.cgi?id=326798</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the vocabulary editor I have just tried the plugins to fetch sounds and images. It seems they work again.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/wiktionary/mwclient/REFERENCE.txt <span style="color: grey">(983df50)</span></li>
<li>plugins/wiktionary/mwclient/README.txt <span style="color: grey">(ff14892)</span></li>
<li>plugins/wiktionary/CMakeLists.txt <span style="color: grey">(860ec65)</span></li>
<li>plugins/wiktionary/mwclient/RELEASE-NOTES.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/__init__.py <span style="color: grey">(3ac2b76)</span></li>
<li>plugins/wiktionary/mwclient/client.py <span style="color: grey">(3eb6d82)</span></li>
<li>plugins/wiktionary/mwclient/compatibility.py <span style="color: grey">(69ee4fc)</span></li>
<li>plugins/wiktionary/mwclient/errors.py <span style="color: grey">(297e6b9)</span></li>
<li>plugins/wiktionary/mwclient/ex.py <span style="color: grey">(afb77d9)</span></li>
<li>plugins/wiktionary/mwclient/http.py <span style="color: grey">(d9ca695)</span></li>
<li>plugins/wiktionary/mwclient/listing.py <span style="color: grey">(a9a50b4)</span></li>
<li>plugins/wiktionary/mwclient/page.py <span style="color: grey">(f7ba897)</span></li>
<li>plugins/wiktionary/mwclient/page_nowriteapi.py <span style="color: grey">(109dccf)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/__init__.py <span style="color: grey">(7738592)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/_speedups.c <span style="color: grey">(8f290bb)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/decoder.py <span style="color: grey">(a1b53b2)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/encoder.py <span style="color: grey">(eec9c7f)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/ordered_dict.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/scanner.py <span style="color: grey">(64f4999)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/__init__.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_check_circular.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_decimal.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_decode.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_default.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_dump.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_encode_basestring_ascii.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_encode_for_html.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_errors.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_fail.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_float.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_indent.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_pass1.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_pass2.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_pass3.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_recursion.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_scanstring.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_separators.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_speedups.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tests/test_unicode.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/simplejson/tool.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/wiktionary/mwclient/upload.py <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113499/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>