<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110617/">http://git.reviewboard.kde.org/r/110617/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 30th, 2013, 2:45 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't want these reviews open for much longer. Can you open a punit/gsoc2013 branch in Khipu with these patches and commit them there? this way you can move forward.</pre>
</blockquote>
<p>On May 30th, 2013, 2:49 p.m. UTC, <b>Punit Mehta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But I dont have the developer rights. So , I guess I cant push my changes there.! </pre>
</blockquote>
<p>On May 30th, 2013, 3:36 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Then just ask for it:
http://techbase.kde.org/Contribute/Get_a_Contributor_Account
You can use me a referral, mention that you're a GSoC student.</pre>
</blockquote>
<p>On May 30th, 2013, 5:37 p.m. UTC, <b>Punit Mehta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks! I have submitted the developer application.</pre>
</blockquote>
<p>On May 31st, 2013, 5:15 a.m. UTC, <b>Percy Camilo Triveño Aucahuasi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Aleix, excellent idea, yes I'm glad Punit can take more active part in the development through a new branch. Please, wait until this weekend, I will notify once the branch is created.
Percy
</pre>
</blockquote>
<p>On June 3rd, 2013, 6:38 a.m. UTC, <b>Percy Camilo Triveño Aucahuasi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done, I've created the gsoc2013 branch (this branch doesn't track master since I'm not going to code until the GSoC end) Punit you have developer rights now (there was 2 users associated with you, contact the admin if was an error)
Percy</pre>
</blockquote>
<p>On June 3rd, 2013, 10:39 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was expecting Punit to create this branch...</pre>
</blockquote>
<p>On June 3rd, 2013, 7:15 p.m. UTC, <b>Percy Camilo Triveño Aucahuasi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh I have misinterpreted; but I know there isn't any problem, the good news are that Punit is already uploading his work into the repo.
Percy</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes..! Percy has already suggested me that he is going to create the branch. So , I thought not to interfere in his work ! :)
By the way , I have already pushed most of the code of my local branch into gsoc2013 remote Khipu branch. Now , I am still working to improve it.</pre>
<br />
<p>- Punit</p>
<br />
<p>On May 30th, 2013, 2:40 p.m. UTC, Punit Mehta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.</div>
<div>By Punit Mehta.</div>
<p style="color: grey;"><i>Updated May 30, 2013, 2:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The diff contains the implementation of the open action in Khipu.! The attached parent diff is for the save action which is already reviewed.!
If the user saves the plotspaces in .khipu file and then he can open the file when he wants.! The initial implementation is done in a way that it considers the case only when on work is done ( i.e the user has just opened the application and then in the very next step , he is going to open his previously saved .khipu file.! I am working for dealing with the other cases also..!
- I have added the entry of plot-colot in the .khipu file as we are requesting and creating the plots when the plotspace-thumbnail is doubleclicked.! So , we need that information also.!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done.! as mentioned , it works very well for the specified case.!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f7dc583)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(0a50c54)</span></li>
<li>src/dashboard.h <span style="color: grey">(a2a9c46)</span></li>
<li>src/dashboard.cpp <span style="color: grey">(688a49d)</span></li>
<li>src/datastore.h <span style="color: grey">(a1276a7)</span></li>
<li>src/datastore.cpp <span style="color: grey">(616e0cc)</span></li>
<li>src/mainwindow.h <span style="color: grey">(1f059f8)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(9d6e010)</span></li>
<li>src/plotseditor.h <span style="color: grey">(47304c6)</span></li>
<li>src/plotseditor.cpp <span style="color: grey">(106cdf5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110617/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>