<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109189/">http://git.reviewboard.kde.org/r/109189/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me, but i have *not* checked the plugin loading still works, if you have checked that and it works i say you can commit it to master just fine.</pre>
<br />
<p>- Albert</p>
<br />
<p>On March 1st, 2013, 2:49 a.m. UTC, David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated March 1, 2013, 2:49 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I started the nowarnings branch with the goal of eliminating all compilation branches in Kig. This will hopefully improve the perceived quality of the current code and help developers spot warnings when submitting new code.
This branch currently compiles without warnings in GCC 4.{6,7,8} and Clang 3.2. While most changes deal with the -Woverloaded-virtual warning in GCC, some changes are worth double checking: kig.cpp, main.cpp and calcpaths.cc.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Compiled and ran the application using GCC 4.6 (32 bits), GCC 4.{7,8} and Clang in (64 bits).
2. Compiled and ran with the --convert-to-native option</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/asyexporter.cc <span style="color: grey">(cbb872f1c3873019d6ca686cf75c7d1613be6a7c)</span></li>
<li>filters/asyexporterimpvisitor.h <span style="color: grey">(630d0915d5211f525f37a8f1f546509ec4c61aef)</span></li>
<li>filters/cabri-filter.cc <span style="color: grey">(411b450355981447f3e901551897968899e03396)</span></li>
<li>filters/latexexporter.cc <span style="color: grey">(9edd34cc88eaf14b479007c4e2e8a1994e9656db)</span></li>
<li>filters/latexexporteroptions.cc <span style="color: grey">(be127827215f8539eebd615c94d09eef643638bc)</span></li>
<li>filters/pgfexporterimpvisitor.h <span style="color: grey">(165f2df8ad9866fd1e43ae4160b90abcf2e74281)</span></li>
<li>filters/xfigexporter.cc <span style="color: grey">(4c26cbff3a8f27b7a07570cb146c59895942c3f3)</span></li>
<li>kig/kig.cpp <span style="color: grey">(af1b9fe775f0115947cb427d3e6d115f88d7507c)</span></li>
<li>kig/main.cpp <span style="color: grey">(94277a308cd83737ba63f803c6852204b05dd0b5)</span></li>
<li>misc/calcpaths.cc <span style="color: grey">(4facd8fb797607fc1e8dc0f13752c98c92a78e9b)</span></li>
<li>misc/special_constructors.cc <span style="color: grey">(23325bdca937b6947d73ccd80ae957c8f3f24346)</span></li>
<li>modes/base_mode.h <span style="color: grey">(e1365c6ebea58e3e010f19ba0a1118eb79970a9b)</span></li>
<li>modes/construct_mode.h <span style="color: grey">(ba069069a7ce62859a2eed43a8d9c4a9e3e78807)</span></li>
<li>modes/macro.h <span style="color: grey">(2d58141c1a3c04877c41343fe24d7b3d10a17618)</span></li>
<li>modes/normal.h <span style="color: grey">(1e11e6f67227eb4d9232470d080877bd9e1ec0e3)</span></li>
<li>objects/conic_types.h <span style="color: grey">(849871f19d13c9b30209d72b3bffc9409cc3d769)</span></li>
<li>objects/line_type.h <span style="color: grey">(5a95552edeb0e73aa13138d7815ed871a65d1347)</span></li>
<li>scripting/python_scripter.cc <span style="color: grey">(7b882bda1b071533407cd880b93586fb2fb2cb92)</span></li>
<li>scripting/script_mode.h <span style="color: grey">(4cbfd73763bef44061fe5a09c6254d95fa884a95)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109189/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>