<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108799/">http://git.reviewboard.kde.org/r/108799/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wow, interesting patch Percy :)
I'd drop the author commands, it doesn't help much and adds clutter.
Also can you check if it's possible to include the code snippets from a file? this way we'll be able to have them compiling, I'd hate to forget them there...
Anyway, just go on and Ship It! (tm), we'll see how to polish it in the future. \o/
</pre>
<br />
<p>- Aleix</p>
<br />
<p>On February 6th, 2013, 8:17 a.m. UTC, Percy Camilo Triveño Aucahuasi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Aleix Pol Gonzalez.</div>
<div>By Percy Camilo Triveño Aucahuasi.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2013, 8:17 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In this patch:
* Improved documentation of Analitza library: tutorials, demos and API reference.
* Some fixes for PlotBuilder and PlotsFactory, note the the need of know about a Variables module have to be inside PlotsFactory an not PlotBuilder, rationale: Some expressions can contains variables of any arbitrary Variables module (See the tutorial 3 in the apidocs)
Best regards,
Percy
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds and also it produces the right html output by doxygen under the parameters of Mainpage.dox.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>Mainpage.dox <span style="color: grey">(0322cd8f0feec89a4c3c35bdb209bcc07f65bdb0)</span></li>
<li>analitza/analitzautils.h <span style="color: grey">(b7edb5ba0a710c665d2260709c2f41f374fc3751)</span></li>
<li>analitza/analyzer.h <span style="color: grey">(f3b3cabc6ecbfcdd8c59b06718e33f6771f81ac1)</span></li>
<li>analitza/apply.h <span style="color: grey">(21032f4aeb4682825afbe19183dc1a78daf3a5e7)</span></li>
<li>analitza/container.h <span style="color: grey">(8d81ab2bc0661eb5e91bb718da6d02f303272565)</span></li>
<li>analitza/customobject.h <span style="color: grey">(afa50b6015dc16e19574dc72766c7a2413fd7b76)</span></li>
<li>analitza/expression.h <span style="color: grey">(b1f8f3edcef4febfdccbd9281953972cd923c1af)</span></li>
<li>analitza/expressionwriter.h <span style="color: grey">(c114df5fbfbc479f30937b1d13dd990bba64eaf9)</span></li>
<li>analitza/htmlexpressionwriter.h <span style="color: grey">(ba84cab40a8ed05610a1d50344be04a648689f58)</span></li>
<li>analitza/importqobjectmetatype.h <span style="color: grey">(25a99aeda448efd562767fae0e64c8b8570823b3)</span></li>
<li>analitza/list.h <span style="color: grey">(7afb72cb0fa2b9e5e9efd383749f1d3d270198b8)</span></li>
<li>analitza/operator.h <span style="color: grey">(dd7a93ed7eb6439cbd39dd28b3302483671854fd)</span></li>
<li>analitza/polynomial.h <span style="color: grey">(ae62055815c030ae2df582296efa614a074c3f06)</span></li>
<li>analitza/providederivative.h <span style="color: grey">(618a35fe74a02f8313e52a6dacc08f8a8d5e94ed)</span></li>
<li>analitza/stringexpressionwriter.h <span style="color: grey">(3d1934919439a4fdc72f7be03549f6d07ab647fb)</span></li>
<li>analitza/value.h <span style="color: grey">(118578ccd77ef42e35356bd2edf31bef883474e7)</span></li>
<li>analitza/variable.h <span style="color: grey">(f8349c411c131ded4154314cb59fc928c63509ec)</span></li>
<li>analitza/variables.h <span style="color: grey">(bf6dd89a789a5bc7819defbd5f1d58566c97649a)</span></li>
<li>analitza/vector.h <span style="color: grey">(035fede8ca1864b262b55fb780c9568ad832d884)</span></li>
<li>analitzagui/algebrahighlighter.h <span style="color: grey">(fd513c88b0b5b3d164db7ad01e275bcc421dbdd6)</span></li>
<li>analitzagui/algebrahighlighter.cpp <span style="color: grey">(da0e09b0dda2831048b7be846aba367d01e2d037)</span></li>
<li>analitzagui/expressionedit.h <span style="color: grey">(031f1a76c559b39a0c469ed5a31d67e31cc4afa2)</span></li>
<li>analitzagui/operatorsmodel.h <span style="color: grey">(16cf3f9313aa7b47e32af1883f056100fbc065aa)</span></li>
<li>analitzagui/operatorsmodel.cpp <span style="color: grey">(fae2f67209cc3b6ed39b097029fb3e822e6c44b0)</span></li>
<li>analitzagui/plotsview2d.h <span style="color: grey">(af83d0657c6f2403e4a455af54d649dd8be3e200)</span></li>
<li>analitzagui/plotsview3d.h <span style="color: grey">(2c12eacff547cc26d52bf92e3efdc7dbe2060d4f)</span></li>
<li>analitzagui/variablesmodel.h <span style="color: grey">(d32f90cdf68f389f2ffe8d6a1e4ab54feda7d3e8)</span></li>
<li>analitzaplot/functiongraph.h <span style="color: grey">(e86d01c74aa6386cee9c4bc4acdb4b98e0102fa1)</span></li>
<li>analitzaplot/planecurve.h <span style="color: grey">(bb8c89786d924a67affbeecd16615ff290761e42)</span></li>
<li>analitzaplot/plotitem.h <span style="color: grey">(5edca2227adf10ce8fe14593c554ae17fe61080e)</span></li>
<li>analitzaplot/plotsfactory.h <span style="color: grey">(3e0d998e1cdd7e18209ae92a07d73894f97406ff)</span></li>
<li>analitzaplot/plotsfactory.cpp <span style="color: grey">(68851b829ea86884842932a6cd4e38cb1fe75b24)</span></li>
<li>analitzaplot/plotsmodel.h <span style="color: grey">(b2357b93e7ccb825ac472e102f930259adc9d7b2)</span></li>
<li>analitzaplot/plotsmodel.cpp <span style="color: grey">(057c50c1e9ac5ec25e1c0c655aa9102868e7a5e9)</span></li>
<li>analitzaplot/plotter2d.h <span style="color: grey">(2f67def8d07f31c1a50a3fca697cdad8bb6e543f)</span></li>
<li>analitzaplot/plotter3d.h <span style="color: grey">(995b67e5e0809edc245e8d316fb879327a9542ae)</span></li>
<li>analitzaplot/spacecurve.h <span style="color: grey">(830114541cf306eb4956914ca1f460f952b85c95)</span></li>
<li>analitzaplot/surface.h <span style="color: grey">(f96fff43ae9badb1e820458daf6d33d5484828f4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108799/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>