<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108053/">http://git.reviewboard.kde.org/r/108053/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 1st, 2013, 8:10 p.m., <b>Laszlo Papp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">IMO, this will be pointless and less readable with Qt5. It is ok for Qt4, though.</pre>
</blockquote>
<p>On January 1st, 2013, 9:53 p.m., <b>Kevin Krammer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Interesting. Qt5 doesn't need to parse method signatures anymore?
What purpose does QMetaObjectPrivate::decodeMethodSignature() have if not parsing the method signature?</pre>
</blockquote>
<p>On January 11th, 2013, 6:46 p.m., <b>Laszlo Papp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As far as I understood the check can be done compilation time with Qt5 (and C++11?), and not runtime.</pre>
</blockquote>
<p>On January 11th, 2013, 6:58 p.m., <b>Kevin Krammer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, only for the new-style connects, when using member functions, functors or lambda expression.
The macro style signal/slot connection is still runtime checked.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, that is what I meant with Qt5 and C++11, and we should switch to that as much as possible. :)
On the other hand, even with the old form, read this: http://lists.kde.org/?l=kde-core-devel&m=132920536226618&w=2
I agree with Ossi about this because if it is a bottleneck, it is just bad since it should not, and it also makes the readability worse without the separators. :)</pre>
<br />
<p>- Laszlo</p>
<br />
<p>On December 31st, 2012, 4:25 p.m., Mayank Madan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Kevin Krammer.</div>
<div>By Mayank Madan.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2012, 4:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixing SIGNAL/SLOT signatures to normalized form as reported by Krazy</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/graticule/GraticulePlugin.cpp <span style="color: grey">(00e69b9)</span></li>
<li>src/plugins/render/positionmarker/PositionMarker.cpp <span style="color: grey">(e18c047)</span></li>
<li>src/plugins/render/satellites/SatellitesConfigDialog.cpp <span style="color: grey">(ce1f211)</span></li>
<li>src/plugins/render/satellites/SatellitesPlugin.cpp <span style="color: grey">(551aef3)</span></li>
<li>src/plugins/render/speedometer/Speedometer.cpp <span style="color: grey">(35eca7b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108053/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>