<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108217/">http://git.reviewboard.kde.org/r/108217/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please initialize iterators in the declaration. Otherwise the objects first get default constructed and then assigned.
In addition, it might be better to cache the "end" iterators.</pre>
<br />
<p>- Jens-Michael</p>
<br />
<p>On January 5th, 2013, 11:22 p.m., Mohammed Nafees wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu, Marble and Kevin Krammer.</div>
<div>By Mohammed Nafees.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2013, 11:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://www.google-melange.com/gci/task/view/google/gci2012/8159207</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/FileManager.cpp <span style="color: grey">(2bac816)</span></li>
<li>src/lib/StackedTileLoader.cpp <span style="color: grey">(962bfef)</span></li>
<li>src/lib/routing/RouteAnnotator.cpp <span style="color: grey">(bf5e6f7)</span></li>
<li>src/plugins/render/opencaching/OpenCachingModel.cpp <span style="color: grey">(e333168)</span></li>
<li>tests/ProjectionTest.cpp <span style="color: grey">(ce6e5d1)</span></li>
<li>tests/RenderPluginTest.cpp <span style="color: grey">(f7dd2e3)</span></li>
<li>tests/TestGeoDataWriter.cpp <span style="color: grey">(a25ba95)</span></li>
<li>tests/TestGeoSceneWriter.cpp <span style="color: grey">(222e22f)</span></li>
<li>tools/osm-addresses/OsmParser.cpp <span style="color: grey">(1a24066)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108217/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>