<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108217/">http://git.reviewboard.kde.org/r/108217/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108217/diff/3/?file=105211#file105211line72" style="color: black; font-weight: bold; text-decoration: underline;">tests/RenderPluginTest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void RenderPluginTest::restoreDefaultSettings_data()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">72</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">QString</span> <span class="n">testName</span> <span class="o">=</span> <span class="n">QString</span><span class="p">(</span> <span class="s">"%1 %2"</span> <span class="p">).</span><span class="n">arg</span><span class="p">(</span> <span class="n">plugin</span><span class="o">-></span><span class="n">nameId</span><span class="p">()</span> <span class="p">).</span><span class="n">arg</span><span class="p">(</span> <span class="n">key</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">72</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QHash</span><span class="o"><</span><span class="n">QString</span><span class="p">,</span> <span class="n">QVariant</span><span class="o">>::</span><span class="n">iterator</span> <span class="k">const</span> <span class="n">endpoint</span> <span class="o">=</span> <span class="n">expected</span><span class="o">-></span><span class="n">settings</span><span class="p">().</span><span class="n">end</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here it is not clear, if the container of the begin iterator is the same like the container of the end iterator. settings() might return a copy. Better get a reference to settings() and then use that for calling begin() and end().
</pre>
</div>
<br />
<p>- Jens-Michael</p>
<br />
<p>On January 6th, 2013, 12:55 p.m., Mohammed Nafees wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu, Marble and Kevin Krammer.</div>
<div>By Mohammed Nafees.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2013, 12:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://www.google-melange.com/gci/task/view/google/gci2012/8159207
fixed Krazy issues on foreach loops</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/FileManager.cpp <span style="color: grey">(2bac816)</span></li>
<li>src/lib/StackedTileLoader.cpp <span style="color: grey">(962bfef)</span></li>
<li>src/lib/routing/RouteAnnotator.cpp <span style="color: grey">(bf5e6f7)</span></li>
<li>src/plugins/render/opencaching/OpenCachingModel.cpp <span style="color: grey">(e333168)</span></li>
<li>tests/ProjectionTest.cpp <span style="color: grey">(ce6e5d1)</span></li>
<li>tests/RenderPluginTest.cpp <span style="color: grey">(f7dd2e3)</span></li>
<li>tests/TestGeoDataWriter.cpp <span style="color: grey">(a25ba95)</span></li>
<li>tests/TestGeoSceneWriter.cpp <span style="color: grey">(222e22f)</span></li>
<li>tools/osm-addresses/OsmParser.cpp <span style="color: grey">(1a24066)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108217/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>