<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108166/">http://git.reviewboard.kde.org/r/108166/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108166/diff/2/?file=104616#file104616line15" style="color: black; font-weight: bold; text-decoration: underline;">kstars/ekos/guide/matr.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">14</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <math.h></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">maybe add an empty line before the "own" include of matr.h and the "foreign" includes starting with math.h</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108166/diff/2/?file=104619#file104619line14" style="color: black; font-weight: bold; text-decoration: underline;">kstars/ekos/guide/vect.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <math.h></span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">14</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <math.h></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">also add empty line between "own" and "foreign" includes</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On January 4th, 2013, 4:42 p.m., Mohammed Nafees wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Kevin Krammer.</div>
<div>By Mohammed Nafees.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2013, 4:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://www.google-melange.com/gci/task/view/google/gci2012/8203202</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">built and tested</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>Tests/CMakeLists.txt <span style="color: grey">(dfaa9d9)</span></li>
<li>Tests/testfwparser.cpp <span style="color: grey">(fc7e83a)</span></li>
<li>datahandlers/CMakeLists.txt <span style="color: grey">(a2d3207)</span></li>
<li>kstars/ekos/capture.cpp <span style="color: grey">(59f203b)</span></li>
<li>kstars/ekos/ekosmanager.cpp <span style="color: grey">(18b8b29)</span></li>
<li>kstars/ekos/guide.cpp <span style="color: grey">(0aca5e9)</span></li>
<li>kstars/ekos/guide/common.cpp <span style="color: grey">(c3a7c08)</span></li>
<li>kstars/ekos/guide/gmath.cpp <span style="color: grey">(042add9)</span></li>
<li>kstars/ekos/guide/guider.cpp <span style="color: grey">(aa85171)</span></li>
<li>kstars/ekos/guide/matr.cpp <span style="color: grey">(25b6b68)</span></li>
<li>kstars/ekos/guide/rcalibration.h <span style="color: grey">(268a49e)</span></li>
<li>kstars/ekos/guide/rcalibration.cpp <span style="color: grey">(3787768)</span></li>
<li>kstars/ekos/guide/vect.cpp <span style="color: grey">(9df115a)</span></li>
<li>kstars/fitsviewer/fitsviewer.cpp <span style="color: grey">(33c2079)</span></li>
<li>kstars/oal/scope.cpp <span style="color: grey">(819bdc0)</span></li>
<li>kstars/options/opssupernovae.cpp <span style="color: grey">(970f116)</span></li>
<li>kstars/printing/legend.cpp <span style="color: grey">(2eddd3c)</span></li>
<li>kstars/printing/printingwizard.cpp <span style="color: grey">(cd75b58)</span></li>
<li>kstars/skycomponents/asteroidscomponent.cpp <span style="color: grey">(b590dfb)</span></li>
<li>kstars/skycomponents/satellitescomponent.cpp <span style="color: grey">(6585d07)</span></li>
<li>kstars/skycomponents/supernovaecomponent.h <span style="color: grey">(f2af09b)</span></li>
<li>kstars/skycomponents/supernovaecomponent.cpp <span style="color: grey">(1c5a34d)</span></li>
<li>kstars/skyglpainter.cpp <span style="color: grey">(22ae124)</span></li>
<li>kstars/skymapqdraw.cpp <span style="color: grey">(a495634)</span></li>
<li>kstars/skyobjects/satellite.cpp <span style="color: grey">(770439f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108166/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>