<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108075/">http://git.reviewboard.kde.org/r/108075/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit a6c7fe18c1071a3d8a818d4e95e8f5d8a6948673 by Kevin Krammer to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 1st, 2013, 11:48 p.m., Kyle Morris wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Kyle Morris.</div>
<p style="color: grey;"><i>Updated Jan. 1, 2013, 11:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add explicit keyword to constructors which could potentially lead to implicit type conversions.
Also included constant values on variables declared within for-each loop.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/AbstractWorkerThread.h <span style="color: grey">(c0b9ee4)</span></li>
<li>src/lib/BookmarkManager_p.h <span style="color: grey">(4fc3b95)</span></li>
<li>src/lib/ElevationModel.h <span style="color: grey">(69f7e6a)</span></li>
<li>src/lib/MapThemeSortFilterProxyModel.h <span style="color: grey">(95902fe)</span></li>
<li>src/lib/MarbleLineEdit.h <span style="color: grey">(08dc049)</span></li>
<li>src/lib/MarblePluginSettingsWidget.h <span style="color: grey">(926bdef)</span></li>
<li>src/lib/Projections/AbstractProjection_p.h <span style="color: grey">(726c1e4)</span></li>
<li>src/lib/Projections/CylindricalProjection_p.h <span style="color: grey">(4eafd01)</span></li>
<li>src/lib/Projections/SphericalProjection_p.h <span style="color: grey">(60d7396)</span></li>
<li>src/lib/RenderPlugin.h <span style="color: grey">(1ae5385)</span></li>
<li>src/lib/Tile.h <span style="color: grey">(84a3991)</span></li>
<li>src/lib/TileScalingTextureMapper.h <span style="color: grey">(cf42d45)</span></li>
<li>src/lib/VectorComposer.h <span style="color: grey">(15bd88f)</span></li>
<li>src/lib/VisiblePlacemark.h <span style="color: grey">(3ca463f)</span></li>
<li>src/lib/blendings/BlendingFactory.h <span style="color: grey">(a931a7b)</span></li>
<li>src/lib/graphicsview/MarbleGraphicsItem.cpp <span style="color: grey">(7c45ba2)</span></li>
<li>src/lib/kineticmodel.h <span style="color: grey">(f505e2e)</span></li>
<li>src/lib/layers/VectorMapLayer.h <span style="color: grey">(91a3f35)</span></li>
<li>tests/ProjectionTest.cpp <span style="color: grey">(ce6e5d1)</span></li>
<li>tests/TestGeoDataWriter.cpp <span style="color: grey">(5d509d7)</span></li>
<li>tests/TestGeoSceneWriter.cpp <span style="color: grey">(bc2b29f)</span></li>
<li>tools/osm-addresses/OsmRegionTree.h <span style="color: grey">(a53b67b)</span></li>
<li>tools/svg2pnt/svgxmlhandler.h <span style="color: grey">(7f899ad)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108075/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>