<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108023/">http://git.reviewboard.kde.org/r/108023/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108023/diff/2/?file=103078#file103078line74" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/geodata/handlers/kml/KmlElementDictionary.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">const char* kmlTag_flyToView = "flyToView";</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">74</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">const</span> <span class="kt">char</span><span class="o">*</span> <span class="n">kmlTag_h</span> <span class="o">=</span> <span class="s"><span class="hl">"h"</span></span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">74</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">const</span> <span class="kt">char</span><span class="o">*</span> <span class="n">kmlTag_h</span> <span class="o">=</span> <span class="sc"><span class="hl">'h'</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this and the other changes in KmlElementDictionary need to be undone.
const char* required the literal to be a string</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On December 30th, 2012, 2:18 p.m., Mayank Madan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Kevin Krammer.</div>
<div>By Mayank Madan.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2012, 2:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Google Code-In Task</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/BookmarkManagerDialog.cpp <span style="color: grey">(41648bd)</span></li>
<li>src/lib/MapWizard.cpp <span style="color: grey">(9aaadf7)</span></li>
<li>src/lib/RenderPluginModel.cpp <span style="color: grey">(96f0477)</span></li>
<li>src/lib/geodata/data/GeoDataOverlay.cpp <span style="color: grey">(d4f5d54)</span></li>
<li>src/lib/geodata/handlers/kml/KmlElementDictionary.cpp <span style="color: grey">(57d07d3)</span></li>
<li>src/lib/routing/instructions/RoutingInstruction.cpp <span style="color: grey">(ed4f03d)</span></li>
<li>src/plugins/declarative/MarbleDeclarativeObject.cpp <span style="color: grey">(05bbbb1)</span></li>
<li>src/plugins/declarative/OfflineDataModel.cpp <span style="color: grey">(eb88d46)</span></li>
<li>src/plugins/render/aprs/AprsPlugin.cpp <span style="color: grey">(4a41a3a)</span></li>
<li>src/plugins/render/earthquake/EarthquakeModel.cpp <span style="color: grey">(d08c982)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp <span style="color: grey">(2951003)</span></li>
<li>src/plugins/render/elevationprofilemarker/ElevationProfileMarker.cpp <span style="color: grey">(4f10b8f)</span></li>
<li>src/plugins/render/foursquare/FoursquareModel.cpp <span style="color: grey">(9f83749)</span></li>
<li>src/plugins/render/opendesktop/OpenDesktopModel.cpp <span style="color: grey">(fcd5271)</span></li>
<li>src/plugins/render/postalcode/PostalCodeModel.cpp <span style="color: grey">(479ce56)</span></li>
<li>src/plugins/render/progress/ProgressFloatItem.cpp <span style="color: grey">(937f862)</span></li>
<li>src/plugins/render/routing/RoutingPlugin.cpp <span style="color: grey">(1300904)</span></li>
<li>src/plugins/render/weather/GeoNamesWeatherService.cpp <span style="color: grey">(94af39c)</span></li>
<li>src/plugins/render/weather/WeatherItem.cpp <span style="color: grey">(46faab7)</span></li>
<li>src/plugins/render/weather/WeatherPlugin.cpp <span style="color: grey">(bb9bf02)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108023/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>