<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103359/">http://git.reviewboard.kde.org/r/103359/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 30th, 2011, 9:24 a.m., <b>Frederik Gladhorn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please break it up into three commits. You wrote yourself that it fixes independent issues.
Check
http://techbase.kde.org/Policies/Kdelibs_Coding_Style
for coding style. Consistency is really helpful when reading the code :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The changes are in different commits, I just forgot to mention it, sorry. I thought it was easier to post them together instead of opening three different review requests for such small patches.
The next time I'll have a look at the coding style before committing the patches. All issues should be fixed now.</pre>
<br />
<p>- Jan Gerrit</p>
<br />
<p>On December 8th, 2011, 8:18 p.m., Jan Gerrit Marker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Jan Gerrit Marker.</div>
<p style="color: grey;"><i>Updated Dec. 8, 2011, 8:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Under some circumstances (close Parley when the welcome screen is opened and start it with a file to open (parley <filename>)) the toolbar of the editor mode is not shown. This patch cleans up that code (removes m_hiddenToolbars in ParleyMainwindow as it is not needed) and fixes the visibility of the toolbar.
* Pressing enter in the last line of the vocabulary table does create a new line but does not edit the new line.
* Parley crashes when a new document is opened via "Open Recent" or "Open".
I searched the open Parley bug reports on bugs.kde.org for these issues but I did not find any report.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes all bugs properly for me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/editor/editor.cpp <span style="color: grey">(243eb70)</span></li>
<li>src/parleymainwindow.h <span style="color: grey">(48e6d1a)</span></li>
<li>src/parleymainwindow.cpp <span style="color: grey">(4ec0526)</span></li>
<li>src/vocabulary/vocabularyview.cpp <span style="color: grey">(84d91c0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103359/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>