<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103325/">http://git.reviewboard.kde.org/r/103325/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, for one thing, the lib does support versioning. It's also possible to accept the old syntax. That is done to keep some compatibility already (I don't remember where without diving into the code right now), though I think it just read the old format without using the version information.
But in this case I'm actually for simply changing the lib and not supporting the old implementation for the simple reason that there was no UI that could edit this before. The only way to actually get the declension info there was by hand. No program made use of this. So let's keep it clean and make it proper.
I think the patch is good. I did not read/test anything really though, sorry.</pre>
<br />
<p>- Frederik</p>
<br />
<p>On December 4th, 2011, 1:50 p.m., Jan Gerrit Marker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Jan Gerrit Marker.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2011, 1:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some languages (Latin, for example) have declensions for adjectives which do not only depend on the number and case but on the gender, too. libkdeedu has an implementation for declensions which does not honor this. This patch corrects that wrong behavior. The change adds an incompatibility to files which were created using the old library. I don't think that there are a lot of files with declensions out there, as for example parley does not have the feature, yet, but if needed I'd try parse old files, too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works with parley, after finishing the implementation of the declension widget (I'll create another review request in order to get this in).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>keduvocdocument/keduvocdeclension.cpp <span style="color: grey">(327c3ed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103325/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>