<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102531/">http://git.reviewboard.kde.org/r/102531/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 6th, 2011, 4:07 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me (note i have only read the code, not compiled nor tested it). What we need to decide now is what to do with the precission setting:
* Nothing (i.e. the user has to set it every time)
* Save it to the file
* Save it to the global user preferences
* Save it to the user preferences in a per file basis
What do you think it is the best?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Save it to the global user preferences. I'd actually add code to save that and the settings for axes and coordinates because there are some users (at me) that hardly ever need the coordinates and axes and end up disabling those every time they start. If so, I'd do that in a different patch with it's own review. Makes sense?</pre>
<br />
<p>- David</p>
<br />
<p>On September 6th, 2011, 10:29 a.m., David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Sept. 6, 2011, 10:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Try to address the feature request at bug 262694 by implementing a configuration dialog to specify coordinate precision on the document. This patch does not deal with saving that information to a file.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Users can choose between default precision handling and specifying one of their own, so test cases are:
1. Start the application, draw a point specifying coordinates
2. Right click on the point and change coordindates - note the coordinate precision used in the display of the coordinates
3. Go to Settings -> Specify Coordinate Precision... and uncheck the option to use default specification
4. Use the spin box to set some coordinate precision, then click Ok
5. Right click on the point and change coordindates - the coordinate precision should have changed to whatever was specified in Step 4
6. Go to Settings -> Specify Coordinate Precision... again - the Use Default checkbox should be unchecked and the spin box should be set to whatever was specified in Step 4
7. Either change precision or use the default, and repeat Steps 4 to 6</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=262694">262694</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(b0f7d52)</span></li>
<li>kig/kig_document.h <span style="color: grey">(010c71b)</span></li>
<li>kig/kig_document.cc <span style="color: grey">(33e6dd7)</span></li>
<li>kig/kig_part.h <span style="color: grey">(bb9b09e)</span></li>
<li>kig/kig_part.cpp <span style="color: grey">(e04f97d)</span></li>
<li>kig/kigpartui.rc <span style="color: grey">(a420963)</span></li>
<li>misc/coordinate_system.cpp <span style="color: grey">(251010b)</span></li>
<li>misc/kigcoordinateprecisiondialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>misc/kigcoordinateprecisiondialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>misc/kigcoordinateprecisiondialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102531/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>