<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102009/">http://git.reviewboard.kde.org/r/102009/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 01297311e9eb5520982ccf6aadbed64e1a382c00 by Jaime Torres to branch 4.7.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 20th, 2011, 6:09 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated July 20, 2011, 6:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove the big memory leaks that the bug talks about.
In the path to the resolution, some virtual destructors were added,
a class member for the radical map, and
the use of clear(). Without it, the list items destructors where not called (at least the kDebug that I enabled did not wrote anything).
And finally, the delete before nullify the pointer and the delete where the pointer is not added to the list.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Run kiten under valgrind. The big memory leaks are gone. There are now only Qt, fontconfig and kdelibs leaks.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=275047">275047</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/kiten.cpp <span style="color: grey">(b403da3)</span></li>
<li>lib/DictEdict/dictfileedict.h <span style="color: grey">(3916149)</span></li>
<li>lib/DictEdict/dictfileedict.cpp <span style="color: grey">(f24a492)</span></li>
<li>lib/DictKanjidic/dictfilekanjidic.h <span style="color: grey">(49eed7f)</span></li>
<li>lib/DictKanjidic/dictfilekanjidic.cpp <span style="color: grey">(318890b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102009/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>