<div class="gmail_quote">On Tue, Jan 4, 2011 at 9:32 PM, Albert Astals Cid <span dir="ltr"><<a href="mailto:aacid@kde.org">aacid@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
A Dimarts, 4 de gener de 2011, Niko Sams va escriure:<br>
<div class="im">> On Mon, Jan 3, 2011 at 18:13, Sebastian Stein <<a href="mailto:seb_stein@gmx.de">seb_stein@gmx.de</a>> wrote:<br>
> > Niko Sams <<a href="mailto:niko.sams@gmail.com">niko.sams@gmail.com</a>> [101227 21:00]:<br>
> >> did this patch reach reach the list?<br>
> ><br>
> > It might be that this patch was caught by a spam filter, but I have not<br>
> > seen it in my inbox. Should we submit it anyway to trunk anyway?<br>
><br>
> well, you shou carefully review first.<br>
><br>
> But I hope this gets submitted, as else split repositories won't be<br>
> possible.<br>
><br>
> I uploaded it here a second time, to avoid anz problems:<br>
> <a href="http://paste.kde.org/1766/" target="_blank">http://paste.kde.org/1766/</a><br>
<br>
</div>I see you removing the cmake files but not adding them anywhere.<br>
It also seems that you want to put that missing files in cmake/ but i think<br>
they should go to cmake/modules<br>
<br>
Also i'm not sure<br>
-include_directories( ${CMAKE_SOURCE_DIR}/libkdeedu/keduvocdocument/ )<br>
+include_directories( .. )<br>
is correct.<br>
<br>
But basically i would not bother about breaking stuff, it's trunk after all,<br>
if you are fairly confident that it works and will be around to fix any<br>
problem that might arise, I'd say that you just commit the patch ;-)<br>
<font color="#888888"><br>
Albert<br>
</font><div><div></div><div class="h5"><br>
><br>
> Niko<br>
> _______________________________________________<br>
> kde-edu mailing list<br>
> <a href="mailto:kde-edu@mail.kde.org">kde-edu@mail.kde.org</a><br>
> <a href="https://mail.kde.org/mailman/listinfo/kde-edu" target="_blank">https://mail.kde.org/mailman/listinfo/kde-edu</a><br>
_______________________________________________<br>
kde-edu mailing list<br>
<a href="mailto:kde-edu@mail.kde.org">kde-edu@mail.kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-edu" target="_blank">https://mail.kde.org/mailman/listinfo/kde-edu</a><br>
</div></div></blockquote></div><br><div>I'd say let's commit something that's somewhat working and ask the teams to organize themselves to get the projects working until a date. I think that would help, to have it there and start being able to fiddle with it.</div>
<div><br></div><div>Aleix</div>