<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5444/">http://svn.reviewboard.kde.org/r/5444/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 25th, 2010, 4:49 p.m., <b>Pino Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This will make drawing a really lot slower for more complex objects (polygons, loci, for example).
Please don't trade a subjective "looking" with an obective "really slow painting".</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It would be good to see some benchmarking on that timing.
It shouldn't be _that_ slower anyway.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On September 25th, 2010, 3:22 p.m., Igor Poboiko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE-Edu.</div>
<div>By Igor Poboiko.</div>
<p style="color: grey;"><i>Updated 2010-09-25 15:22:37</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This simple patch adds an QPainter::Antialiasing hint for Kig's painter.
I think smoothed scene looks much better (actually, IMHO without it scene looks a little ugly) and a bit usablier than previous one (see attached screenshots)
P.S Looks like Kig is using it's own "reinvented wheel" to paint all objects.
Why don't Kig use Qt Graphics View framework (QGraphicsView/QGraphicsScene/etc)? What do you think about porting Kig to it? (I know that it is an off-topic for this review request, but I want to know your ideas about it)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kig from KDE 4.5.1 (tested with Qt 4.7.0) compiles with this patch and works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/kig/misc/kigpainter.cpp <span style="color: grey">(1173923)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5444/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5444/s/509/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/24/no_antialiasing_400x100.png" style="border: 1px black solid;" alt="Without antialiasing" /></a>
<a href="http://svn.reviewboard.kde.org/r/5444/s/510/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/24/antialiasing_400x100.png" style="border: 1px black solid;" alt="With antialiasing" /></a>
<a href="http://svn.reviewboard.kde.org/r/5444/s/513/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/25/antialiasing_without_axis_400x100.png" style="border: 1px black solid;" alt="With antialiasing (but not for axis&grid)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>