<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4616/">http://reviewboard.kde.org/r/4616/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 15th, 2010, 11:58 a.m., <b>Alexander Rieder</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>Hi,
it looks like to forgot to add the src/lib/ dir and src/lib/backendtest.*files into the patch</pre>
</blockquote>
</blockquote>
<pre>i mean src/lib/test and src/lib/test/backendtest.*</pre>
<br />
<p>- Alexander</p>
<br />
<p>On July 14th, 2010, 5:53 p.m., Miha Cancula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE-Edu and Alexander Rieder.</div>
<div>By Miha Cancula.</div>
<p style="color: grey;"><i>Updated 2010-07-14 17:53:51</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This patch introduces a BackendTest class which has the functionality previously shared by tests for Maxima and Sage backends. I also included a test for the new Octave backend, which also uses the same class.
The only new functionality is skipping tests for backends which are not usable (either not installed or missing runtime requirements). Otherwise it's mostly copy/paste, so I kept Alexander's copyright in the new class. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">All three tests compile and run. Maxima's testPlot fails, but I think that happened before the change too. I don't have Sage installed, so its test is successfully skipped. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/cantor/CMakeLists.txt <span style="color: grey">(1149794)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/CMakeLists.txt <span style="color: grey">(1149794)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/maxima/CMakeLists.txt <span style="color: grey">(1149810)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/maxima/testmaxima.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/maxima/testmaxima.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/octave/CMakeLists.txt <span style="color: grey">(1149810)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/octave/testoctave.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/octave/testoctave.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/sage/CMakeLists.txt <span style="color: grey">(1149810)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/sage/testsage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/backends/sage/testsage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/src/lib/CMakeLists.txt <span style="color: grey">(1149794)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/CMakeLists.txt <span style="color: grey">(1149809)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/testmaxima.h <span style="color: grey">(1149809)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/testmaxima.cpp <span style="color: grey">(1149809)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/testsage.h <span style="color: grey">(1149809)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/testsage.cpp <span style="color: grey">(1149809)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4616/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>