<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4616/">http://reviewboard.kde.org/r/4616/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 13th, 2010, 3:34 p.m., <b>Aleix Pol</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>I don't think there should be backend-dependent code/tests outside src/backends.</pre>
</blockquote>
<p>On July 13th, 2010, 4:59 p.m., <b>Miha Cancula</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>It was there already, but I suppose it can be moved to src/backends/, and backend-specific classes to their respective folders. </pre>
</blockquote>
</blockquote>
<pre>Yes, I agree. It was a bad idea to not keep the tests in the same location as the backend.
About the placing of the BackendTest class, I'm not sure. Normally things shared between backends go to the lib directory, but this is a special case as it won't be compiled most of the time, and really shoudlnt be in the cantorlib library.
Basically I see 2 solutions:
- create a subdir in lib and new library called cantortest or something, that for now only contains this class but who knows the future, and have the backends tests all link against that
- put it inside src/backends/ as Miha proposed, allthough that looks a bit strange, having one single class there that doesn't really belong anywhere
I'm open for good suggestions on this one.</pre>
<br />
<p>- Alexander</p>
<br />
<p>On July 13th, 2010, 12:30 p.m., Miha Cancula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE-Edu and Alexander Rieder.</div>
<div>By Miha Cancula.</div>
<p style="color: grey;"><i>Updated 2010-07-13 12:30:43</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This patch introduces a BackendTest class which has the functionality previously shared by tests for Maxima and Sage backends. I also included a test for the new Octave backend, which also uses the same class.
The only new functionality is skipping tests for backends which are not usable (either not installed or missing runtime requirements). Otherwise it's mostly copy/paste, so I kept Alexander's copyright in the new class. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">All three tests compile and run. Maxima's testPlot fails, but I think that happened before the change too. I don't have Sage installed, so its test is successfully skipped. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/cantor/tests/testoctave.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/testoctave.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/testmaxima.h <span style="color: grey">(1149413)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/testmaxima.cpp <span style="color: grey">(1149413)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/backendtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/CMakeLists.txt <span style="color: grey">(1149413)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/backendtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/testsage.h <span style="color: grey">(1149413)</span></li>
<li>/trunk/KDE/kdeedu/cantor/tests/testsage.cpp <span style="color: grey">(1149413)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4616/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>