D25078: Replace deprecated KConfigDialogManager::changedMap with property in the class definition

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Wed Nov 27 00:08:37 GMT 2019


kossebau added a comment.


  EquationEdit != EquationEditWidget
  
  You rather want to add a `NOTIFY textEdited` to the property definition of `text` for class `EquationEdit`,  at https://phabricator.kde.org/source/kmplot/browse/master/kmplot/equationedit.h$52 :)
  
  EquationEdit is used with ui files for kcfgx-based settings UI, so making KConfigDialogManager aware of the property change signal is needed to update config editing status (e.g. to enable Apply/Ok buttons).
  See e.g. https://phabricator.kde.org/source/kmplot/browse/master/kmplot/editcoords.ui

REPOSITORY
  R334 KmPlot

REVISION DETAIL
  https://phabricator.kde.org/D25078

To: yurchor, #kde_edu
Cc: kossebau, aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191127/956b678f/attachment.html>


More information about the kde-edu mailing list