D16173: Fix regression on job deletion when sorting jobs based on alitude and priority is enabled.

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  Refactoring job manipulation did include both arrows for job reordering and button for job deletion.
  When using that refactored function to prevent reordering of jobs sorted by altitude and priority, the job deletion was mistakenly impacted too.
  This differential fixes this issue.

TEST PLAN
  Disable Ekos option "Sort Jobs by Altitude and Priority", and load or create a schedule.
  Observe as jobs can be reordered and deleted without issue.
  Enable Ekos option "Sort Jobs by Altitude and Priority".
  BUG: Observe as the button bar does not change when saving settings, but updates as soon as a job is clicked.
  Without this differential, clicking on a job disables the reorder buttons and the delete button.
  With this differential, clicking on a job disables the reorder buttons, but not the delete button.
  Check that starting the scheduler still disables both reorder and delete buttons, and that stopping resets them based on the sort option.
  Check that both reorder and delete buttons are disabled when there is no job in the list.
  Check that the reorder buttons are disabled, but the delete button is kept enabled when there is one single job in the list.
  
  Note: this will need a signal to indicate options were updated, so that UI may react to changes immediately.

REPOSITORY
  R321 KStars

BRANCH
  bugfix__regression_job_deletion (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16173

AFFECTED FILES
  kstars/ekos/scheduler/scheduler.cpp
  kstars/ekos/scheduler/scheduler.h

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181013/1cfdb8db/attachment.html>