Review Request 130224: fixes bug "Relative path for audio files not working"

Albert Astals Cid aacid at kde.org
Sun Aug 13 15:42:20 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130224/#review103606
-----------------------------------------------------------



Looks good, i'm going to go an extra step and ask.

Do you think you could either add an autotest (or improve one of the existing ones) to check this so we don't regress again?

If you think it's too much or need help, just say it :)

- Albert Astals Cid


On Aug. 12, 2017, 8:20 p.m., René Fritz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130224/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2017, 8:20 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 381349
>     https://bugs.kde.org/show_bug.cgi?id=381349
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> description is in bug report https://bugs.kde.org/show_bug.cgi?id=381349
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/readerwriters/keduvockvtml2reader.cpp d5322f51266da66247248776430efa0cb7f98fdc 
> 
> Diff: https://git.reviewboard.kde.org/r/130224/diff/
> 
> 
> Testing
> -------
> 
> urls like "file:somepath/file.mp3" are parsed correctly again and sound is played
> 
> 
> Thanks,
> 
> René Fritz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20170813/f6514973/attachment.html>


More information about the kde-edu mailing list