Review Request 122877: Move Parley's editor model classes into libkeduvocdocument

[Jeremy Whiting]

> On March 9, 2015, 2:59 p.m., Inge Wallin wrote:
> > keduvocdocument/keduvocvocabularymodel.cpp, lines 215-224
> > <https://git.reviewboard.kde.org/r/122877/diff/1/?file=353919#file353919line215>
> >
> >     A tooltip sounds like something that belongs in an application rather than in a library.  This should probably be in Parley instead of here.  Check if it's possible to move or if it really needs to be here.
> >     
> >     Also check if there are more tooltips in other models.

Nope. Tooltips text come from the model in Qt's Model/View system. How would parley give tooltips for items in the model? This belongs here.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122877/#review77230
-----------------------------------------------------------


On March 9, 2015, 2:05 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122877/
> -----------------------------------------------------------
> 
> (Updated March 9, 2015, 2:05 p.m.)
> 
> 
> Review request for KDE Edu, Inge Wallin and Jeremy Whiting.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> The model classes of parley's editor is moved into libkeduvocdocument. As a result we can have an editor in the library itself, and the applications won't need to keep their separate editors.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 09aed2b 
>   keduvocdocument/CMakeLists.txt 6eeba12 
>   keduvocdocument/keduvoccontainermimedata.h PRE-CREATION 
>   keduvocdocument/keduvoccontainermimedata.cpp PRE-CREATION 
>   keduvocdocument/keduvoccontainermodel.h PRE-CREATION 
>   keduvocdocument/keduvoccontainermodel.cpp PRE-CREATION 
>   keduvocdocument/keduvoclessonmodel.h PRE-CREATION 
>   keduvocdocument/keduvoclessonmodel.cpp PRE-CREATION 
>   keduvocdocument/keduvocreadonlycontainermodel.h PRE-CREATION 
>   keduvocdocument/keduvocreadonlycontainermodel.cpp PRE-CREATION 
>   keduvocdocument/keduvocvocabularymimedata.h PRE-CREATION 
>   keduvocdocument/keduvocvocabularymimedata.cpp PRE-CREATION 
>   keduvocdocument/keduvocvocabularymodel.h PRE-CREATION 
>   keduvocdocument/keduvocvocabularymodel.cpp PRE-CREATION 
>   keduvocdocument/keduvocwordclassmodel.h PRE-CREATION 
>   keduvocdocument/keduvocwordclassmodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122877/diff/
> 
> 
> Testing
> -------
> 
> It builds and runs with no errors.
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150529/df446fa6/attachment.html>