<table><tr><td style="">dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29871">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29871#inline-172030">View Inline</a><span style="color: #4b4d51; font-weight: bold;">index.docbook:2141</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><term><guimenuitem>Set Show Hidden Folders</guimenuitem></term>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><listitem><para>Toggle whether hidden folders should be shown in the treeview.</para></listitem>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"></varlistentry>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">hidden folders (whose name starts with a dot)</p>
<p style="padding: 0; margin: 8px;">That's what this is all about, right?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29871#inline-172027">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sidebar_widget.cpp:339</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">bool</span> <span class="n">canToggle</span> <span style="color: #aa2211">=</span> <span class="n">currentButtonInfo</span><span class="p">().</span><span class="n">canToggleShowHiddenFolders</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">canToggle</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">bool</span> <span class="n">newToggleState</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">!</span><span class="n">currentButtonInfo</span><span class="p">().</span><span class="n">showHiddenFolders</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This should be an assert instead, you don't create the action if canToggle... is false.</p>
<p style="padding: 0; margin: 8px;">Q_ASSERT(currentButtonInfo().canToggleShowHiddenFolders);</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29871#inline-172031">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sidebar_widget.cpp:543</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">buttonInfo</span><span class="p">.</span><span class="n">configOpen</span> <span style="color: #aa2211">=</span> <span class="n">configGroup</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"Open"</span><span class="p">,</span> <span style="color: #304a96">false</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">buttonInfo</span><span class="p">.</span><span class="n">canToggleShowHiddenFolders</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">!</span> <span class="n">configGroup</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"ShowHiddenFolders"</span><span class="p">,</span> <span class="n">QString</span><span class="p">()).</span><span class="n">isEmpty</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">buttonInfo</span><span class="p">.</span><span class="n">showHiddenFolders</span> <span style="color: #aa2211">=</span> <span class="n">configGroup</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"ShowHiddenFolders"</span><span class="p">,</span> <span style="color: #304a96">false</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why not enable the feature for *any* button that ends up creating a KonqSideBarTreeModule?</p>
<p style="padding: 0; margin: 8px;">Otherwise, as a user, I do "RMB / Add New / Tree Sidebar Module", configure its URL to /tmp or whatever and the feature is broken there.</p>
<p style="padding: 0; margin: 8px;">By not making the on/off dependent on the desktop file entry, maybe one day we can change the storing of the on/off status to be per-directory. Availability of the feature and on/off storage should be separate.<br />
And since it's available for any user of KDirModel, I'd just make it depend on the module being used.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29871#inline-172029">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sidebar_widget.cpp:580</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">currentButtonInfo</span><span class="p">().</span><span class="n">showHiddenFolders</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">buttonPopup</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span><span class="n">QIcon</span><span style="color: #aa2211">::</span><span class="n">fromTheme</span><span class="p">(</span><span style="color: #766510">"fileopen"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Hide Hidden Folders..."</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">slotToggleShowHiddenFolders</span><span class="p">()));</span> <span style="color: #74777d">// NOTE: does it matter that it toggles? Race conditions?</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"Hide Hidden" feels weird.</p>
<p style="padding: 0; margin: 8px;">Please copy Dolphin. It uses a toggle action "Show Hidden Folders", the text doesn't change, just the checkmark in front.</p>
<p style="padding: 0; margin: 8px;">QWidget is all single threaded, I wonder which race condition you have in mind here, please explain.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29871#inline-172028">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tree_module.cpp:77</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// treeView->header()->setSectionResizeMode(0, QHeaderView::ResizeToContents);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// treeView->header()->setSectionResizeMode(0, QHeaderView::Stretch);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">//treeView->header()->setStretchLastSection(false);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please don't add dead code.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R226 Konqueror</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29871">https://phabricator.kde.org/D29871</a></div></div><br /><div><strong>To: </strong>rrosch, dfaure<br /><strong>Cc: </strong>kde-doc-english, gennad, fbampaloukas, skadinna<br /></div>