<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22594">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22594#inline-168537">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pdabrowski</span> wrote in <span style="color: #4b4d51; font-weight: bold;">dolphinmainwindow.cpp:2289</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">So, the URL does not have any impact on the search tool chosen? I thought that was the main reason for using the URL and updating it all the time.</p></blockquote>
<p style="padding: 0; margin: 8px;">This depends on KMoreToolsMenuFactory. But it doesn't seem to choose different tools for different URLs.</p>
<p style="padding: 0; margin: 8px;">The main reason for the updates was so that all the Open Preferred Search Tool actions reflect the user choice of preferred tool (can be modified with More Search Tools -> More -> Configure)<br />
See: <a href="https://phabricator.kde.org/D22594#499652" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D22594#499652</a></p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">(can be modified with More Search Tools -> More -> Configure)</p></blockquote>
<p style="padding: 0; margin: 8px;">Then there should be a signal in <tt style="background: #ebebeb; font-size: 13px;">KMoreTools</tt> a user of this class can connect to to get notified when user preference changes. Or, the actions were actually governed by <tt style="background: #ebebeb; font-size: 13px;">KMoreTools</tt> and automatically updated.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R318 Dolphin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22594">https://phabricator.kde.org/D22594</a></div></div><br /><div><strong>To: </strong>pdabrowski, Dolphin, ngraham, elvisangelaccio<br /><strong>Cc: </strong>broulik, pkloc, kfm-devel, kde-doc-english, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, rdieter, mikesomov<br /></div>