<table><tr><td style="">aprcela added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29006">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D29006#662058" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29006#662058</a>, <a href="https://phabricator.kde.org/p/meven/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@meven</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Just a check to add.</p></div>
</blockquote>
<p><a href="https://phabricator.kde.org/p/meven/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@meven</a> See inline comment</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D29006#662094" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29006#662094</a>, <a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Actually, wait, I vote against Ctrl+<a href="https://phabricator.kde.org/F5" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5</a>/Ctrl+F6 because these shortcuts, by default, in Plasma, are bound to "Switch to Desktop 5" and "Switch to Desktop 6".</p>
<p>Shift+<a href="https://phabricator.kde.org/F5" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5</a>/F6 would be much better, if it's available.</p>
<p>Meven: drag-n-drop is 'easy' but it requires using the mouse. For accessibility, or for people stuck on a plane with a bad touchpad and no room for a real mouse, or simply for maximum performance in optimized workflows, I can see the benefit of keyboard shortcuts.</p>
<p>Just not if they switch desktops inadvertently, once you configure 6+ virtual desktops :-)</p></div>
</blockquote>
<p><tt style="background: #ebebeb; font-size: 13px;">Shift+F5/F6</tt> seems to bee free. So we could go with that.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29006#inline-167998">View Inline</a><span style="color: #4b4d51; font-weight: bold;">meven</span> wrote in <span style="color: #4b4d51; font-weight: bold;">dolphinmainwindow.cpp:1993</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">This is not sufficient, you can copy or move to <tt style="background: #ebebeb; font-size: 13px;">recentlyused:/files/</tt> for instance, which fails.<br />
So test the other view url to see if it is writable as well.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'm trying to add a check and it only doesn't work only on this kind of folders. Works fine with local and samba share. See diff:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="diff" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp</span>
<span style="color: #000080">index 428c61952..5e7c56385 100644</span>
<span style="color: #a00000">--- a/src/dolphinmainwindow.cpp</span>
<span style="color: #00a000">+++ b/src/dolphinmainwindow.cpp</span>
<span style="color: #800080">@@ -1959,7 +1959,7 @@ void DolphinMainWindow::updateFileAndEditActions()</span>
{
const KFileItemList list = m_activeViewContainer->view()->selectedItems();
const KActionCollection* col = actionCollection();
<span style="color: #a00000">- KFileItemListProperties capabilities(list);</span>
<span style="color: #00a000">+ KFileItemListProperties capabilitiesSource(list);</span>
QAction* addToPlacesAction = col->action(QStringLiteral("add_to_places"));
QAction* copyToOtherViewAction = col->action(QStringLiteral("copy_to_other_split_view"));
<span style="color: #800080">@@ -1989,22 +1989,31 @@ void DolphinMainWindow::updateFileAndEditActions()</span>
}
if (m_tabWidget->currentTabPage()->splitViewEnabled()) {
<span style="color: #a00000">- copyToOtherViewAction->setEnabled(true);</span>
<span style="color: #a00000">- moveToOtherViewAction->setEnabled(capabilities.supportsMoving());</span>
<span style="color: #00a000">+ DolphinTabPage* tabPage = m_tabWidget->currentTabPage();</span>
<span style="color: #00a000">+ KFileItem capabilitiesDestination;</span>
<span style="color: #00a000">+</span>
<span style="color: #00a000">+ if (tabPage->primaryViewActive()) {</span>
<span style="color: #00a000">+ capabilitiesDestination = tabPage->secondaryViewContainer()->url();</span>
<span style="color: #00a000">+ } else {</span>
<span style="color: #00a000">+ capabilitiesDestination = tabPage->primaryViewContainer()->url();</span>
<span style="color: #00a000">+ }</span>
<span style="color: #00a000">+</span>
<span style="color: #00a000">+ copyToOtherViewAction->setEnabled(capabilitiesDestination.isWritable());</span>
<span style="color: #00a000">+ moveToOtherViewAction->setEnabled(capabilitiesSource.supportsMoving() && capabilitiesDestination.isWritable());</span>
} else {
copyToOtherViewAction->setEnabled(false);
moveToOtherViewAction->setEnabled(false);
}
<span style="color: #a00000">- const bool enableMoveToTrash = capabilities.isLocal() && capabilities.supportsMoving();</span>
<span style="color: #00a000">+ const bool enableMoveToTrash = capabilitiesSource.isLocal() && capabilitiesSource.supportsMoving();</span>
<span style="color: #a00000">- renameAction->setEnabled(capabilities.supportsMoving());</span>
<span style="color: #00a000">+ renameAction->setEnabled(capabilitiesSource.supportsMoving());</span>
moveToTrashAction->setEnabled(enableMoveToTrash);
<span style="color: #a00000">- deleteAction->setEnabled(capabilities.supportsDeleting());</span>
<span style="color: #a00000">- deleteWithTrashShortcut->setEnabled(capabilities.supportsDeleting() && !enableMoveToTrash);</span>
<span style="color: #a00000">- cutAction->setEnabled(capabilities.supportsMoving());</span>
<span style="color: #00a000">+ deleteAction->setEnabled(capabilitiesSource.supportsDeleting());</span>
<span style="color: #00a000">+ deleteWithTrashShortcut->setEnabled(capabilitiesSource.supportsDeleting() && !enableMoveToTrash);</span>
<span style="color: #00a000">+ cutAction->setEnabled(capabilitiesSource.supportsMoving());</span>
showTarget->setEnabled(list.length() == 1 && list.at(0).isLink());
<span style="color: #a00000">- duplicateAction->setEnabled(capabilities.supportsWriting());</span>
<span style="color: #00a000">+ duplicateAction->setEnabled(capabilitiesSource.supportsWriting());</span>
}
}</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R318 Dolphin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29006">https://phabricator.kde.org/D29006</a></div></div><br /><div><strong>To: </strong>aprcela, Dolphin, elvisangelaccio, ngraham, meven, dfaure<br /><strong>Cc: </strong>yurchor, kde-doc-english, dfaure, meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, rdieter, mikesomov<br /></div>