<table><tr><td style="">elvisangelaccio requested changes to this revision.<br />elvisangelaccio added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22594">View Revision</a></tr></table><br /><div><div><p>Almost there!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22594#inline-138469">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pdabrowski</span> wrote in <span style="color: #4b4d51; font-weight: bold;">dolphinmainwindow.cpp:916-919</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">There is no other way to update the open_preferred_search_tool action *before* the Configure Shortcuts window is shown.<br />
This action is then listed in that window, so it should be up-to-date when it is displayed.<br />
This update is instantaneous if user made no changes to the search tools in the meantime.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please write this information in a comment above that <tt style="background: #ebebeb; font-size: 13px;">connect()</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22594#inline-139177">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dolphinmainwindow.cpp:968</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QAction</span><span style="color: #aa2211">*</span> <span class="n">openPreferredSearchTool</span> <span style="color: #aa2211">=</span> <span class="n">actionCollection</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">action</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"open_preferred_search_tool"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QWidget</span><span style="color: #aa2211">*></span> <span class="n">widgets</span> <span style="color: #aa2211">=</span> <span class="n">openPreferredSearchTool</span><span style="color: #aa2211">-></span><span class="n">associatedWidgets</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span> <span class="p">(</span><span class="n">QWidget</span><span style="color: #aa2211">*</span> <span style="color: #a0a000">widget</span> <span class="p">:</span> <span class="n">widgets</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing <tt style="background: #ebebeb; font-size: 13px;">const</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22594#inline-139176">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dolphinpart.cpp:536</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QString<span class="bright"></span></span><span class="bright"> </span><span class="n"><span class="bright">dir</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QDir</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">hom</span>ePath</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QUrl</span> <span style="color: #004012">u</span><span class="p">(</span><span class="n">url</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #74777d">// If the given directory is not local, it can still be the URL of an</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #74777d">// ioslave using UDS_LOCAL_PATH which to be converted first.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">StatJob</span><span style="color: #aa2211">*</span> <span class="n">statJob</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">mostLocalUrl</span><span class="p">(</span><span class="n">u</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">KJobWidgets</span><span style="color: #aa2211">::</span><span class="n">setWindow</span><span class="p">(</span><span class="n">statJob</span><span class="p">,</span> <span class="n">widget</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">statJob</span><span style="color: #aa2211">-></span><span class="n">exec</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">u</span> <span style="color: #aa2211">=</span> <span class="n">statJob</span><span style="color: #aa2211">-></span><span class="n">mostLocalUrl</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #74777d">//If the URL is local after the above conversion, set the directory.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">u</span><span class="p">.</span><span class="n">isLocalFile</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">dir</span> <span style="color: #aa2211">=</span> <span class="n">u</span><span class="p">.</span><span class="n">toLocalFile</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">KToolInvocation</span><span style="color: #aa2211">::</span><span class="n">invokeTerminal</span><span class="p">(</span><span class="n">QString</span><span class="p">(),</span> <span class="n">dir</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">KToolInvocation</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">invokeTerminal</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">QString<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span class="n"><span class="bright">KParts</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">ReadOnlyPart</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">localFil</span>ePath</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is an unrelated change actually, isn't it? It makes sense, but it should go in another commit.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R318 Dolphin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22594">https://phabricator.kde.org/D22594</a></div></div><br /><div><strong>To: </strong>pdabrowski, Dolphin, ngraham, elvisangelaccio<br /><strong>Cc: </strong>pkloc, kfm-devel, kde-doc-english, iasensio, fprice, gennad, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, mikesomov<br /></div>