<table><tr><td style="">ltoscano added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23229">View Revision</a></tr></table><br /><div><div><p>I can't check now, but I think the case were "the deprecated variable is set, but the new one is not, then the old one is used" should be considered.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23229#inline-131075">View Inline</a><span style="color: #4b4d51; font-weight: bold;">KF5DocToolsMacros.cmake:236</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #304a96">if</span> <span class="p">(</span><span style="color: #766510">NOT</span> <span class="bright"></span><span style="color: #766510"><span class="bright">MAN</span>_INSTALL_DIR</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #304a96">set</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">MAN</span>_INSTALL_DIR</span> <span style="color: #766510">share/man</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">if</span> <span class="p">(</span><span style="color: #766510">NOT</span> <span class="bright"></span><span style="color: #766510"><span class="bright">KDE</span>_INSTALL_<span class="bright">MAN</span>DIR</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">set</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">KDE</span>_INSTALL_<span class="bright">MAN</span>DIR</span> <span style="color: #766510">share/man</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #304a96">endif</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I wonder if we should consider the deprecated variable as well. It's deprecated, but if it has been set, and the new one is not set, the old one should be probably used.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23229#inline-131076">View Inline</a><span style="color: #4b4d51; font-weight: bold;">KF5DocToolsMacros.cmake:239</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #304a96">if</span> <span class="p">(</span><span style="color: #766510">NOT</span> <span class="bright"></span><span style="color: #766510"><span class="bright">HTML</span>_INSTALL_DIR</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #304a96">set</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">HTML</span>_INSTALL_DIR</span> <span style="color: #766510">share/doc/HTML</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">if</span> <span class="p">(</span><span style="color: #766510">NOT</span> <span class="bright"></span><span style="color: #766510"><span class="bright">KDE</span>_INSTALL_<span class="bright">DOCBUNDLE</span>DIR</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">set</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">KDE</span>_INSTALL_<span class="bright">DOCBUNDLE</span>DIR</span> <span style="color: #766510">share/doc/HTML</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #304a96">endif</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Aee above.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R238 KDocTools</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23229">https://phabricator.kde.org/D23229</a></div></div><br /><div><strong>To: </strong>asturmlechner, Frameworks<br /><strong>Cc: </strong>ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna<br /></div>