<table><tr><td style="">elvisangelaccio requested changes to this revision.<br />elvisangelaccio added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22444">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22444#496089" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D22444#496089</a>, <a href="https://phabricator.kde.org/p/elvisangelaccio/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@elvisangelaccio</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Please use a descriptive commit message: <a href="https://community.kde.org/Policies/Commit_Policy#Always_add_descriptive_log_messages" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Policies/Commit_Policy#Always_add_descriptive_log_messages</a></p></div>
</blockquote>
<p>Still not fixed ;)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22444#inline-129291">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dolphinviewactionhandler.cpp:192</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QAction</span><span style="color: #aa2211">*</span> <span class="n">zoomResetAction</span> <span style="color: #aa2211">=</span> <span class="n">m_actionCollection</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"view_zoom_reset"</span><span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">zoomResetAction</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"@action:inmenu View"</span><span class="p">,</span> <span style="color: #766510">"Reset Zoom Level"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please remove the spaces before/after <tt style="background: #ebebeb; font-size: 13px;">QStringLiteral</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22444#inline-129292">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dolphinviewactionhandler.cpp:203</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_actionCollection</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">zoomOutAction</span><span style="color: #aa2211">-></span><span class="n">setWhatsThis</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"@info:whatsthis zoom <span class="bright">in</span>"</span><span class="p">,</span> <span style="color: #766510">"This reduces the icon size."</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">zoomOutAction</span><span style="color: #aa2211">-></span><span class="n">setWhatsThis</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"@info:whatsthis zoom <span class="bright">out</span>"</span><span class="p">,</span> <span style="color: #766510">"This reduces the icon size."</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated change, should go to its own commit. (feel free to push it without review...)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22444#inline-129295">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dolphinviewactionhandler.cpp:468-486</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ViewSettingsTab</span><span style="color: #aa2211">::</span><span class="n">Mode</span> <span class="n">settingsMode</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">switch</span> <span class="p">(</span><span class="n">m_currentView</span><span style="color: #aa2211">-></span><span class="n">mode</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">case</span> <span class="n">DolphinView</span><span style="color: #aa2211">::</span><span style="color: #a0a000">IconsView</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">settingsMode</span> <span style="color: #aa2211">=</span> <span class="n">ViewSettingsTab</span><span style="color: #aa2211">::</span><span class="n">IconsMode</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">break</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">case</span> <span class="n">DolphinView</span><span style="color: #aa2211">::</span><span style="color: #a0a000">DetailsView</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">settingsMode</span> <span style="color: #aa2211">=</span> <span class="n">ViewSettingsTab</span><span style="color: #aa2211">::</span><span class="n">DetailsMode</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Sorry but I don't like this solution (i.e. creating a settings tab widget inside the action handler). Please try the following instead:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Create a new method <tt style="background: #ebebeb; font-size: 13px;">DolphinView::resetZoomLevel()</tt>.</li>
<li class="remarkup-list-item">Call <tt style="background: #ebebeb; font-size: 13px;">settings->useDefaults(true)</tt> where <tt style="background: #ebebeb; font-size: 13px;">settings</tt> is one of <tt style="background: #ebebeb; font-size: 13px;">IconsModeSettings::self()</tt>, <tt style="background: #ebebeb; font-size: 13px;">CompactModeSettings::self()</tt>, or <tt style="background: #ebebeb; font-size: 13px;">DetailsModeSettings::self()</tt> (depending on the current <tt style="background: #ebebeb; font-size: 13px;">DolphinView::viewMode()</tt>).</li>
<li class="remarkup-list-item">Get the default zoom value from <tt style="background: #ebebeb; font-size: 13px;">ViewModeSettings::iconSize()</tt>.</li>
</ol></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R318 Dolphin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22444">https://phabricator.kde.org/D22444</a></div></div><br /><div><strong>To: </strong>ngraham, elvisangelaccio, shubham, Dolphin<br /><strong>Cc: </strong>cfeck, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov<br /></div>