<table><tr><td style="">pdabrowski added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22594">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The way you've implemented the menu item naming seems a bit fragile though</p></blockquote>
<p>True. It's really hard to update it reliably.<br />
KMoreTools* do not provide an easy way to get notified that the tools changed. Even current solution in "More Search Tools" menu recreates the menu every time it is displayed.<br />
So I tried updating the action every time menu containing it is shown. Connect()ions for this aren't pretty, but this should actually work...</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>In my testing, the name doesn't show up and it falls back to the static name.</p></blockquote>
<p>This is strange, because this action should be updated on many occasions, including Dolphin startup.<br />
Or is your testcase installing KFind while Dolphin is open, or doing something similar? (Either way, that should work too).</p>
<p>Please let me know a test scenario that fails.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R318 Dolphin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22594">https://phabricator.kde.org/D22594</a></div></div><br /><div><strong>To: </strong>pdabrowski, Dolphin, ngraham, elvisangelaccio<br /><strong>Cc: </strong>kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov<br /></div>