<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22594">View Revision</a></tr></table><br /><div><div><p>All right, you've convinced me on the shortcut.</p>
<p>The way you've implemented the menu item naming seems a bit fragile though (and in line 1410 of <tt style="background: #ebebeb; font-size: 13px;">src/dolphinmainwindow.cpp</tt>, it's not used at all). In my testing, the name doesn't show up and it falls back to the static name. If you can't find a way to implement the feature reliably, it may be best to just always show static text. But it would be nice to have the name of the app reliably show up there, though.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R318 Dolphin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22594">https://phabricator.kde.org/D22594</a></div></div><br /><div><strong>To: </strong>pdabrowski, Dolphin, ngraham, elvisangelaccio<br /><strong>Cc: </strong>kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov<br /></div>