<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17120">View Revision</a></tr></table><br /><div><div><p>I *have not tried* it.</p>
<p>I think the code is in good enough shape now.</p>
<p>If you're confident with your testing is good enough, for me you can commit it (with the const fix)</p>
<p>If you want someone else to give it a test say so and i'll test it a bit.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17120#inline-95019">View Inline</a><span style="color: #4b4d51; font-weight: bold;">view.cpp:3689</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">QRectF</span> <span class="n">View</span><span style="color: #aa2211">::</span><span class="n">getViewport</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this function should probably be const</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R334 KmPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17120">https://phabricator.kde.org/D17120</a></div></div><br /><div><strong>To: </strong>yurchor, KDE Edu, tcanabrava<br /><strong>Cc: </strong>cfeck, aacid, tcanabrava, kde-edu, kde-doc-english, skadinna, narvaez, apol<br /></div>