<table><tr><td style="">rkflx created this revision.<br />rkflx added a reviewer: Gwenview.<br />Restricted Application added a project: Documentation.<br />Restricted Application added a subscriber: kde-doc-english.<br />rkflx requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14103">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p><a href="https://phabricator.kde.org/D14093" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14093</a> will add back middle-clicking to toggle between <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Fit</span></span></span> (with<br />
<kbd style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">F</kbd> as its keyboard shortcut) and <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">100%</span></span></span> zoom. In addition,<br />
<a href="https://phabricator.kde.org/D14094" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14094</a> sets <kbd title="Shift" style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">⇧</kbd><span class="kbd-join" style="padding: 0 4px; color: #92969D;">+</span><kbd style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">F</kbd> as a shortcut for <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Fill</span></span></span>.</p>
<p>Going along with this, here we add <kbd title="Shift" style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">⇧</kbd>-middle-clicking for<br />
<span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Fill</span></span></span>. The code is moved to <tt style="background: #ebebeb; font-size: 13px;">DocumentView</tt> in order not to<br />
duplicate the handling of the toggling behaviour.</p>
<p>We also adapt the docbook accordingly, as some users still seem to read<br />
the manual.</p>
<p>CCBUG: 396360</p>
<p>Depends on <a href="https://phabricator.kde.org/D14093" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14093</a></p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Middle-click multiple times on an image in <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">View</span></span></span> mode and observe<br />
<span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Fit</span></span></span> is toggled. Repeat while holding down <kbd title="Shift" style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">⇧</kbd> for<br />
<span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Fill</span></span></span>.<br />
Proof-read docbook ("View mode" and "Tips" sections).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R260 Gwenview</div></div></div><br /><div><strong>BRANCH</strong><div><div>middle-click-zooming</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14103">https://phabricator.kde.org/D14103</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>doc/index.docbook<br />
lib/documentview/abstractimageview.cpp<br />
lib/documentview/documentview.cpp<br />
lib/documentview/documentview.h</div></div></div><br /><div><strong>To: </strong>rkflx, Gwenview<br /><strong>Cc: </strong>kde-doc-english, skadinna<br /></div>