<table><tr><td style="">the requested changes to this revision.<br />the added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13589">View Revision</a></tr></table><br /><div><div><p>Your steps 1. ... 10. look ok to me -> accepted.</p>
<ol class="remarkup-list" start="11">
<li class="remarkup-list-item">what are those final points good for? There is a simple list with some tokens / abbrev., not complete sentences. IMHO that change is wrong. Additionally: all these texts are created by a tool (extracted from source code) and will be overwritten the next time I run that tool. This means that these texts have to be in sync with the source code (which also does not support entities).</li>
</ol>
<ol class="remarkup-list" start="12">
<li class="remarkup-list-item">ok, accepted</li>
</ol>
<ol class="remarkup-list" start="13">
<li class="remarkup-list-item">I am not sure, isn't 	 a predefined entity for the tabulator key? Then it would be mis-used in that case.</li>
</ol>
<p>How did you take the screenshot? Please do not manually create screenshots! There is a Kwave macro file (scripts/screenshots.kwave) that should be used to create all screenshots, in a unified way, showing the same content for all languages.</p>
<p>BTW: This is a lot of stuff to review and comment within one single pass, it would be easier if things had been split into several steps.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R347 KWave</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13589">https://phabricator.kde.org/D13589</a></div></div><br /><div><strong>To: </strong>Abella, the<br /><strong>Cc: </strong>ltoscano, kde-doc-english, skadinna<br /></div>