<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129025/">https://git.reviewboard.kde.org/r/129025/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 26th, 2016, 4:25 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Again, I'll refer to how it's done in KCoreAddons. I don't think it's really useful to need to define variables for every framework you are compiling.</p></pre>
</blockquote>
<p>On September 26th, 2016, 4:28 p.m. CEST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is this last sentence part of another conversation that I missed?</p></pre>
</blockquote>
<p>On September 26th, 2016, 4:40 p.m. CEST, <b>Ralf Habacker</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch does it the same way as already implemented in kcoreaddons https://github.com/KDE/kcoreaddons/blob/master/KF5CoreAddonsConfig.cmake.in#L11.</p></pre>
</blockquote>
<p>On September 26th, 2016, 5:03 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The part I was referring to is actually:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">if(CMAKE_CROSSCOMPILING AND KF5_HOST_TOOLING)
find_file(TARGETSFILE KF5CoreAddons/KF5CoreAddonsToolingTargets.cmake PATHS <span style="color: #BC7A00">${</span>KF5_HOST_TOOLING<span style="color: #BC7A00">}</span> <span style="color: #BC7A00">${</span>CMAKE_CURRENT_LIST_DIR<span style="color: #BC7A00">}</span> NO_DEFAULT_PATH)
include("<span style="color: #BC7A00">${</span>TARGETSFILE<span style="color: #BC7A00">}</span>")
else()
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think we should take into account CROSSCOMPILING if KF5_HOST_TOOLING isn't specified. Including the target files should define all the needed targets.</p></pre>
</blockquote>
<p>On September 26th, 2016, 5:57 p.m. CEST, <b>Ralf Habacker</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@alex: You remember that I asked about 8 month ago about an example how to implement this way and did not get any answer ? Any now you insist to use a broken way without any help or tutorial ?</p></pre>
</blockquote>
<p>On September 26th, 2016, 7:37 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My apologies if I haven't been verbose enough. I can try to document <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KF5_HOST_TOOLING</code> later tonight. Would that help?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My name is Aleix.</p></pre>
</blockquote>
<p>On September 27th, 2016, 12:23 a.m. CEST, <b>Ralf Habacker</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@aleix: From my experience on adding cross compile support at https://build.opensuse.org/project/monitor/home:rhabacker:branches:windows:mingw:win32:KF526, which is complete and works, there are several details to cover and I'm not sure how much work remains to make it complete using the KF5_HOST_TOOLING way after you documentated it. Because the original KDE cmake guru abandoned his approach to implement cross compile support with KDE 4.5 and never resumes it looks really to have some major issues. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My suggestion is therefore to complete the recent approach (which can coexist with the incomplete KF5_HOST_TOOLING stuff if wished) to have a stable and working solution and then to see how to improve cross compile support by supporting the KF5_HOST_TOOLING way.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In short my approach compiles required native cross tools at home:rhabacker:branches:KDE:Frameworks526 (kcoreaddons and sonnet also includes required tools for cross compiling but related kf5 packages version 5.26 already installs them unconditionally in the development package. (With a few pending kf5 build system related patches reviewed this project can be skipped). </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">At https://build.opensuse.org/project/monitor/home:rhabacker:branches:windows:mingw:win32:KF526 all required native tools are packaged (and relocated to /usr/bin/<cross-prefix>-<toolname>) by the mingw32-cross-kf5-tools package.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With this and other mingw32-cross... packages provided by the opensuse windows:mingw:win32 project, windows kf5 packages are build. The mingw32-kxx packages fetches kf5 source packages extracted directly from kde git server using tags and uses local patches from for fixing remaining issues (for example https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF526/mingw32-kdoctools).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BTW: Sorry for using wrong name.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Whatever, what can I say?
If you ask me, it looks like an ad-hoc solution to get your thing working there, but if that will bear any positive results then go for it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+0 from me.</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On September 26th, 2016, 4:23 p.m. CEST, Ralf Habacker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Documentation, KDE Frameworks and Luigi Toscano.</div>
<div>By Ralf Habacker.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2016, 4:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Enable cross compilation support for packages depending on normally installed kdoctools tools.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KF5DocToolsConfig.cmake.in <span style="color: grey">(9224fd2788aee5db4340cd0ac8115c1a06ca8ebe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129025/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>