<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128292/">https://git.reviewboard.kde.org/r/128292/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It looks good for a first version, thanks!
I found only a few minor issues below:
At keywords, I would use "dvb-t" instead of "dvbt". I would also add: "dvb-c", "dvb-s", "isdb-t", "dvb-t2", "dvb-s2".
"uses LibVLC for the backend it supports all the same file formats as VLC.", I guess there's a comma there: "uses LibVLC for the backend, it supports all the same file formats as VLC."
"In &kaffeine; version 2.0 the digital TV support was extended to support DVB-T2 and ISDB-T.", I guess there's a comma there: "In &kaffeine; version 2.0, the digital TV support was extended to support DVB-T2 and ISDB-T."</pre>
<br />
<p>- Mauro Carvalho Chehab</p>
<br />
<p>On June 26th, 2016, 5:08 p.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Documentation, Kaffeine and Mauro Carvalho Chehab.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated June 26, 2016, 5:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kaffeine
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">content + screenshots from https://blogs.s-osg.org/watching-digital-tv-via-kaffeine/ Mauro Carvalho Chehab</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">passes checkXML5</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/discwindow.png <span style="color: grey">(3690fc0)</span></li>
<li>doc/document-save.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/dvbbroadcast.png <span style="color: grey">(92f1181)</span></li>
<li>doc/dvbclient.png <span style="color: grey">(c780765)</span></li>
<li>doc/dvbconfig.png <span style="color: grey">(66cd07a)</span></li>
<li>doc/dvbepg.png <span style="color: grey">(ab16367)</span></li>
<li>doc/dvblive.jpg <span style="color: grey">(0d6948f)</span></li>
<li>doc/dvbscan.png <span style="color: grey">(5143f19)</span></li>
<li>doc/dvbtimers.png <span style="color: grey">(dbfa976)</span></li>
<li>doc/dvbwin.png <span style="color: grey">(2150238)</span></li>
<li>doc/gstpart.png <span style="color: grey">(d3f60ca)</span></li>
<li>doc/index.docbook <span style="color: grey">(3f069a7)</span></li>
<li>doc/kaffeine_configure_tv_dvbc_dvbt2_device.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kaffeine_configure_tv_isdb_device.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kaffeine_initial.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kaffeine_live_tv.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kaffeine_play_file.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kaffeine_program_guide.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kaffeine_recording_schedule_enabled.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kaffeine_scan_channel_edit.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kaffeine_scan_finished_channels_added.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kaffeinepart.png <span style="color: grey">(fe108b7)</span></li>
<li>doc/media-playback-pause.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/media-record.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/playlistwin.png <span style="color: grey">(9c6a283)</span></li>
<li>doc/playlistwindow.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/startwindow.png <span style="color: grey">(bfdfa83)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128292/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>