<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128123/">https://git.reviewboard.kde.org/r/128123/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-1 for several reasons:
if you change the version number because of code changes, this does not
automatically mean the docbook has been updated as well.
the template.docbook in kdoctools has:
<title>The &kmyapplication; Handbook</title> -> no version in title
A comment when to change date/releaseinfo
Change date/releasinfo if
docbook is updated and verified to be valid for the current app version
docbook is proofreaded and verified to be valid for the current app version
all project docbooks, but not the code where @KAFFEINE_VERSION@ is defined are pulled
locally into l10n-kf5/documentation, so we can use tools like grep or scripts
to e.g find docbooks older than x years or x releases, or search for translated
language docbooks with date + releaseinfo != english docbooks
this does not work with a CMake variable, but requires literal strings
for date and releaseinfo
Please discard this review, I have already changed the title locally in my
updated handbook</pre>
<br />
<p>- Burkhard Lück</p>
<br />
<p>On Juni 8th, 2016, 12:33 vorm. UTC, Mauro Carvalho Chehab wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Documentation, Kaffeine and Burkhard Lück.</div>
<div>By Mauro Carvalho Chehab.</div>
<p style="color: grey;"><i>Updated Juni 8, 2016, 12:33 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kaffeine
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use cmake to update the docbook version</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">IMHO, instead of hardcoding the Kaffeine version at the documentation, we could use cmake to auto-generate with the enclosed patch.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/CMakeLists.txt <span style="color: grey">(06f05fb82675)</span></li>
<li>doc/index.docbook <span style="color: grey">(3f069a7f857b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128123/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>