<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128086/">https://git.reviewboard.kde.org/r/128086/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good as a first step to cleanup it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Answering some of the FIXMEs:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) I guess that, instead of the Sourceforge references, we could point to: https://www.kde.org/applications/multimedia/kaffeine/. That page should be updated too... In special, it doesn't give any credits to the original Kaffeine authors, and mentions the author that moved the code from SF to KDE as if he was the only author.
2) The only backend currently enabled is VLC. the mplayer backend is currently disabled. So, there's no menu to select the backend;
3) The old DCOP interface was replaced by QMessageBus. It seems that the conversion was based on this document: https://techbase.kde.org/Development/Tutorials/Porting_to_D-Bus. So, the API calls documented there should be changed. I didn't test to see if it is still working, but I guess it should work fine.
4) I guess we can remove the emacs macros at the end of the docbook file too.</p></pre>
<br />
<p>- Mauro Carvalho Chehab</p>
<br />
<p>On June 3rd, 2016, 2:31 p.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Documentation and Mauro Carvalho Chehab.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated June 3, 2016, 2:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kaffeine
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">remove all superfluous comments
use entity kaffeine
add a lot of FIXME's with questions + hints what needs to be checked/updated
nor ready for production</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">passes checkXML5</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/index.docbook <span style="color: grey">(8d8a73e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128086/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>