<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127949/">https://git.reviewboard.kde.org/r/127949/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 26th, 2016, 3:41 p.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, ok, arrived here now.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Feel free to commit this.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have commited one plugin doc change for the revived xmlcheck plugin:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://phabricator.kde.org/rKATE8721cd331f4c</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If this messes something up for you, revert it and apply your stuff and ping me to reapply that afterwards.
Thanks.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry that I had no time to look at stuff here since long :/</p></pre>
</blockquote>
<p>On May 26th, 2016, 4:24 p.m. UTC, <b>Burkhard Lück</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Your commit with the xmlcheck plugin (much appreciated by me, thanks) introduced an additional para + one varlistentry:
1)
<varlistentry>
<term><guilabel>File Type</guilabel></term>
<listitem><para>Select the file type(s) you want the snippet repository to apply
to. It is set to <quote>*</quote> by default, so the repository applies to all files. You
can change it to something like <userinput>C++</userinput> for instance, or select
from a list by hitting the <guibutton>Edit</guibutton>. You can specify more
than one file type by separating them with <userinput>;</userinput>.</para></listitem>
</varlistentry>
Afaik this is not correct because you have to press &Shift; to specify more than one file; not to type ";"
and this is already in line 1434-1441 in the patch for plugins.docbook,
so I would remove it.
2)
<para>In <guilabel>Snippet Content</guilabel> you can specify variables with
<userinput>${<replaceable>name</replaceable>}</userinput> or
<userinput>%{<replaceable>name</replaceable>}</userinput>. These can be filled
by QtScript or when the snippet is used. There is a special variable -
${cursor} or %{cursor} - which automatically sets the cursor to its first
occurrence.</para>
This is already in lines 1471 - 1492 in the patch for plugins.docbook, right?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Afaik this is not correct because you have to press &Shift; to specify more than one file; not to type ";"
and this is already in line 1434-1441 in the patch for plugins.docbook,
so I would remove it.
Please do so ;=)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is already in lines 1471 - 1492 in the patch for plugins.docbook, right?
Seems duplicated, yeah :/</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Btw.: Thanks for all your fixes and improvements!</p></pre>
<br />
<p>- Christoph</p>
<br />
<p>On May 19th, 2016, 2:21 p.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Documentation and Kate.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated May 19, 2016, 2:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kate is by kde, not for kde
move all plugin related info to plugin.docbook
remove all obsolete infos for kate plugins
add a lot of FIXME's for missing content, will be updated in next RR
objective of this RR is to get all obsolete/wrong info stripped off from the docbook
feel free to add comments/reviews to my FIXME's, but even without them the updated docbooks are better for our users</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">passes checkXML5</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/kate/configuring.docbook <span style="color: grey">(5d11629)</span></li>
<li>doc/kate/fundamentals.docbook <span style="color: grey">(3f6bcc2)</span></li>
<li>doc/kate/gdb-settings.png <span style="color: grey">(0c92bb8)</span></li>
<li>doc/kate/index.docbook <span style="color: grey">(368cf63)</span></li>
<li>doc/kate/menus.docbook <span style="color: grey">(717bddd)</span></li>
<li>doc/kate/plugins.docbook <span style="color: grey">(d24c3d0)</span></li>
<li>doc/kate/snippets-form.png <span style="color: grey">(66875c1)</span></li>
<li>doc/kate/snippets-panel.png <span style="color: grey">(281948c)</span></li>
<li>doc/kate/snippets-usage.png <span style="color: grey">(7851e05)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127949/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>