<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124341/">https://git.reviewboard.kde.org/r/124341/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 14th, 2015, 8:29 a.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/124341/file/2192/" style="color: black; font-weight: bold; font-size: 9pt;">strange-buttons.png</a>
<p>What is the meaning of these buttons?</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the three-state radio button. It's indicating enabled-by-default.</pre>
</blockquote>
<p>On July 23rd, 2015, 8:17 p.m. CEST, <b>Burkhard Lück</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"radio button" ? It looks and behaves like a check box
Why have only these two effects a three-state button, afaik more effects are enabled in a fresh kf5 installation (in an VM or build from sources)</pre>
</blockquote>
<p>On July 24th, 2015, 6:33 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">sorry: typo, I meant "three-state check box"</p></pre>
</blockquote>
<p>On July 24th, 2015, 6:34 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and it's also more than enabled-by-default: it's actually evaluated at runtime whether it's supported and only if supported it gets enabled by default.</p></pre>
</blockquote>
<p>On August 2nd, 2015, 11:02 p.m. CEST, <b>Burkhard Lück</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Martin, what does that tristate check box mean for joe user?
Thre are more effects enabled by default afaik
And what about the rest of the update?
Is it ok? Needs corrections or improvements?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tristate means: enabled by default if the hardware supports it.</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On July 13th, 2015, 9:46 p.m. CEST, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Documentation and Martin Gräßlin.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated July 13, 2015, 9:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I used a lot of infos from Martins blog, many thanks</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">http://blog.martin-graesslin.com/blog/2014/03/desktop-effects-control-module-in-kwin5/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A small part is a copy from kwincompositing docbook</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/CMakeLists.txt <span style="color: grey">(2768884)</span></li>
<li>doc/kwineffects/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwineffects/configure-effects.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwineffects/configure-filter.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwineffects/dialog-information.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwineffects/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwineffects/video.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124341/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/7f2ae492-482e-4ccc-8f77-29fe06ba487d__strange-buttons.png">What is the meaning of these buttons?</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>