<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124542/">https://git.reviewboard.kde.org/r/124542/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On agosto 1st, 2015, 11:35 p.m. CEST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looking back at the review which introduced the escaping, namely https://git.reviewboard.kde.org/r/120648/ , I escaped the comma as well in the first review. I don't remember why I removed them. Apart from that usage, comma are invalid characters in NTFS (according https://kb.acronis.com/content/39790) so we shouldn't hit them; they could work on ext[234]/xfs/whatever but I think that libxml2 could handle them. The only thing I would like to test (and if you volunteer for that I wouldn't complain :) is a test where the path to the DTD does contain a comma, to be sure that not escaping it does work on Linux. Or we could just call it as "don't do that" and forget about it :)</p></pre>
</blockquote>
<p>On agosto 2nd, 2015, 1:26 a.m. CEST, <b>Dāvis Mosāns</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Comma is not invalid character for NTFS, maybe you meant colon ":"?
Anyway in either case NTFS have 2 file namespaces, one is Win32 where invalid characters are</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">NUL</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">/ (slash)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">\ (backslash)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">: (colon)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">* (asterisk)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">? (Question mark)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">" (quote)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">< (less than)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">> (greater than)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">| (pipe)</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and other is POSIX namespace where all Unicode code points are valid except NUL and / (slash).
On Linux, NTFS-3G by default will create all files in POSIX namespace thus it will allow creating filename with colon ":" and other "illegal" characters in NTFS.
And on Windows if you use WinAPI directly you can also create such filenames in POSIX namespace.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As for which characters to escape in URI, see https://url.spec.whatwg.org/#url-code-points and also RFCs 1738, 2396, 3986. Both comma and colon is allowed in URI so seems bug is somewhere else and this is just a workaround.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, sorry, I meant colon. The entire sentence should be read with "colon" instead of "comma".
I guess we mostly care for the Win32 namespace, but in any case, colon are needed there for the drive letter. Anyway, as you mentioned, colon are allowed in URI and the proper format for an URI in windows is file:///C:/whatever/etc/etc1/etc2/myfile.txt, so it looks like a problem in libxml2, but given that the timeframe for fixing that would be too long, I would say to workaround it for now by escaping the colon (in the proper place).</p></pre>
<br />
<p>- Luigi</p>
<br />
<p>On agosto 1st, 2015, 11:40 a.m. CEST, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Documentation, KDE Frameworks and Luigi Toscano.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Ago. 1, 2015, 11:40 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=348061">348061</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: 348061</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adding ':' to the list of escaped characters is probably not an ideal solution, but let me hear your ideas.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/uriencode.cmake <span style="color: grey">(e5f3c3acd93d3871e44b6e6fb29ad7113e18d751)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124542/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>