<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124250/">https://git.reviewboard.kde.org/r/124250/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Juli 5th, 2015, 12:59 nachm. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This adds a new directory called "kcontrol". Would it not be better to drop this KDE 3.5 term and replace it with what it's about? E.g. "lockscreen" or "screenlocker"?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, because
1) The new directory called "kcontrol is consistent with nearly all other kcm docbooks (one except is kwin - see 3)
2) Scripty needs the directory "kcontrol" to generate entries with the correct install path for CMakelists.txt in the language docbook directories
3) For the kwin kcm docbooks not beeing in a subdir kcontrol the file http://websvn.kde.org/trunk/l10n-kf5/scripts/documentation_paths?view=markup
needs five entries to "add" the necessary kcontrol dir for scripty instead of one entries with kwin kcm docbooks in a subdir kcontrol</pre>
<br />
<p>- Burkhard</p>
<br />
<p>On Juli 6th, 2015, 9:54 vorm. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Documentation and Plasma.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Juli 6, 2015, 9:54 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add missing screenlocker docbook, a modified copy from kde-workspace / doc / kcontrol / screensaver / index.docbook @ KDE/4.11</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds and is opened an Help Action in KCM</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/CMakeLists.txt <span style="color: grey">(0eb36a6)</span></li>
<li>doc/kcontrol/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/screenlocker/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/screenlocker/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcm/screenlocker.desktop <span style="color: grey">(19caa3b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124250/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>