<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122245/">https://git.reviewboard.kde.org/r/122245/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On gener 25th, 2015, 3:36 p.m. UTC, <b>Pino Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You don't need to move the English documentation from doc/en to doc, for making it work with Scripty...</p></pre>
</blockquote>
<p>On gener 25th, 2015, 4:31 p.m. UTC, <b>Burkhard Lück</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That's true, but I'd like to have a minimal numebers of exceptions from the policy "docbooks in /doc or /docs"
It makes applying changes to documentation_paths less error-prone.</p></pre>
</blockquote>
<p>On gener 25th, 2015, 4:40 p.m. UTC, <b>Pino Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you please point me where this policy is set?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't see anything wrong with having English documentation under doc/en, and from some point of view also eases the release process a bit (doc/CMakeLists.txt can be totally autogenerated, for example).
This was done in the past by a couple of extragear, which have been changed from doc/en from doc for apparently no reason other than "others do this"...</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"Others do this" is actually a very good reason. Uniformity makes it easier for everyone to understand what's going on.</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On gener 25th, 2015, 2:29 p.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Documentation, Localization and Translation (l10n), Thomas Eschenbacher, and Yuri Chornoivan.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated gen. 25, 2015, 2:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwave
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">delete all po files and localized screenshots, they will be imported into trunk/l10n-kde4 before this commit</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">mv en docbookspngs to proper location in source</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">adapt CMakeLists.txt</p>
</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@ Thomas Eschenbacher:
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> I did not find a Messages.sh in the source tree, please add it
</em> /CMakeLists.txt needs mor clean up wrt documentation and translation</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds and is properly translated</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/audio2signal.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/cs/kwave-fileinfo.png <span style="color: grey">(e781989)</span></li>
<li>doc/cs/kwave-gui-mdi.png <span style="color: grey">(5d723a9)</span></li>
<li>doc/cs/kwave-gui-sdi.png <span style="color: grey">(58f124d)</span></li>
<li>doc/cs/kwave-gui-tab.png <span style="color: grey">(4842f62)</span></li>
<li>doc/cs/kwave-lowpass.png <span style="color: grey">(735b5f1)</span></li>
<li>doc/cs/kwave-main.png <span style="color: grey">(e5e0618)</span></li>
<li>doc/cs/kwave-memory-setup.png <span style="color: grey">(5a2bd96)</span></li>
<li>doc/cs/kwave-newfile.png <span style="color: grey">(cf4e606)</span></li>
<li>doc/cs/kwave-notchfilter.png <span style="color: grey">(d036362)</span></li>
<li>doc/cs/kwave-pitch.png <span style="color: grey">(bbc2e90)</span></li>
<li>doc/cs/kwave-playback-setup.png <span style="color: grey">(9785d93)</span></li>
<li>doc/cs/kwave-record.png <span style="color: grey">(0c0930c)</span></li>
<li>doc/cs/kwave-sonagram-setup.png <span style="color: grey">(18bc211)</span></li>
<li>doc/cs/kwave-sonagram.png <span style="color: grey">(5579d1b)</span></li>
<li>doc/cs/kwave-volume.png <span style="color: grey">(7762882)</span></li>
<li>doc/de/kwave-fileinfo.png <span style="color: grey">(684e30b)</span></li>
<li>doc/de/kwave-gui-mdi.png <span style="color: grey">(a7602cc)</span></li>
<li>doc/de/kwave-gui-sdi.png <span style="color: grey">(9658408)</span></li>
<li>doc/de/kwave-gui-tab.png <span style="color: grey">(b05f588)</span></li>
<li>doc/de/kwave-lowpass.png <span style="color: grey">(da1f4db)</span></li>
<li>doc/de/kwave-main.png <span style="color: grey">(b18705f)</span></li>
<li>doc/de/kwave-memory-setup.png <span style="color: grey">(6c4f38e)</span></li>
<li>doc/de/kwave-newfile.png <span style="color: grey">(d50230c)</span></li>
<li>doc/de/kwave-notch-filter.png <span style="color: grey">(65c0a68)</span></li>
<li>doc/de/kwave-pitch.png <span style="color: grey">(940361d)</span></li>
<li>doc/de/kwave-playback-setup.png <span style="color: grey">(fc1bdc0)</span></li>
<li>doc/de/kwave-record.png <span style="color: grey">(ed3cfe1)</span></li>
<li>doc/de/kwave-sonagram-setup.png <span style="color: grey">(1fbf81b)</span></li>
<li>doc/de/kwave-sonagram.png <span style="color: grey">(6548733)</span></li>
<li>doc/de/kwave-volume.png <span style="color: grey">(39950d0)</span></li>
<li>doc/en/audio-1.png <span style="color: grey">(e71261a)</span></li>
<li>doc/en/audio2signal.png <span style="color: grey">(517293c)</span></li>
<li>doc/en/krec_record.png <span style="color: grey">(fa8c4d7)</span></li>
<li>doc/en/kwave-fileinfo.png <span style="color: grey">(c9135f0)</span></li>
<li>doc/en/kwave-gui-mdi.png <span style="color: grey">(4b937a5)</span></li>
<li>doc/en/kwave-gui-sdi.png <span style="color: grey">(4582548)</span></li>
<li>CMakeLists.txt <span style="color: grey">(2497ac4)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(a3a98c6)</span></li>
<li>doc/audio-1.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/en/kwave-memory-setup.png <span style="color: grey">(bbc8de9)</span></li>
<li>doc/en/kwave-newfile.png <span style="color: grey">(b87a865)</span></li>
<li>doc/en/kwave-notch-filter.png <span style="color: grey">(6c7e286)</span></li>
<li>doc/en/kwave-pitch.png <span style="color: grey">(94b3d2e)</span></li>
<li>doc/en/kwave-playback-setup.png <span style="color: grey">(560a6a6)</span></li>
<li>doc/en/kwave-record.png <span style="color: grey">(5d406a9)</span></li>
<li>doc/en/kwave-sonagram-setup.png <span style="color: grey">(c27405e)</span></li>
<li>doc/en/kwave-sonagram.png <span style="color: grey">(1873be2)</span></li>
<li>doc/en/kwave-volume.png <span style="color: grey">(d854eef)</span></li>
<li>doc/en/light_off.png <span style="color: grey">(ddd370b)</span></li>
<li>doc/en/light_on.png <span style="color: grey">(2ef9f36)</span></li>
<li>doc/en/nonlinear.png <span style="color: grey">(be88507)</span></li>
<li>doc/en/record_new.png <span style="color: grey">(1e8857e)</span></li>
<li>doc/en/record_pause.png <span style="color: grey">(d1cb113)</span></li>
<li>doc/en/record_stop.png <span style="color: grey">(4e87227)</span></li>
<li>doc/en/signal2digital.png <span style="color: grey">(b812967)</span></li>
<li>doc/en/signed.png <span style="color: grey">(80034c8)</span></li>
<li>doc/en/sinus2samples.png <span style="color: grey">(e451557)</span></li>
<li>doc/en/under-construction.png <span style="color: grey">(13dae2e)</span></li>
<li>doc/en/unsigned.png <span style="color: grey">(7b2cc6c)</span></li>
<li>doc/es/kwave-fileinfo.png <span style="color: grey">(79ab985)</span></li>
<li>doc/es/kwave-gui-mdi.png <span style="color: grey">(526bfd8)</span></li>
<li>doc/es/kwave-gui-sdi.png <span style="color: grey">(9dcf815)</span></li>
<li>doc/es/kwave-gui-tab.png <span style="color: grey">(4047c50)</span></li>
<li>doc/es/kwave-lowpass.png <span style="color: grey">(a85bba5)</span></li>
<li>doc/es/kwave-main.png <span style="color: grey">(b5dbbbe)</span></li>
<li>doc/es/kwave-memory-setup.png <span style="color: grey">(750cb33)</span></li>
<li>doc/es/kwave-newfile.png <span style="color: grey">(7f01df8)</span></li>
<li>doc/es/kwave-notch-filter.png <span style="color: grey">(b75dfb5)</span></li>
<li>doc/es/kwave-pitch.png <span style="color: grey">(11f754e)</span></li>
<li>doc/es/kwave-playback-setup.png <span style="color: grey">(f25d81b)</span></li>
<li>doc/es/kwave-record.png <span style="color: grey">(348fa0e)</span></li>
<li>doc/es/kwave-sonagram-setup.png <span style="color: grey">(2f5731d)</span></li>
<li>doc/es/kwave-sonagram.png <span style="color: grey">(b4c95ed)</span></li>
<li>doc/es/kwave-volume.png <span style="color: grey">(4446720)</span></li>
<li>doc/fr/kwave-fileinfo.png <span style="color: grey">(4582869)</span></li>
<li>doc/fr/kwave-lowpass.png <span style="color: grey">(8dffc23)</span></li>
<li>doc/fr/kwave-main.png <span style="color: grey">(ddf1923)</span></li>
<li>doc/fr/kwave-memory-setup.png <span style="color: grey">(c2538f5)</span></li>
<li>doc/fr/kwave-newfile.png <span style="color: grey">(4351994)</span></li>
<li>doc/fr/kwave-notch-filter.png <span style="color: grey">(a8ecb28)</span></li>
<li>doc/fr/kwave-pitch.png <span style="color: grey">(07627f6)</span></li>
<li>doc/fr/kwave-playback-setup.png <span style="color: grey">(d3d8b6d)</span></li>
<li>doc/fr/kwave-record.png <span style="color: grey">(b656ea7)</span></li>
<li>doc/fr/kwave-sonagram-setup.png <span style="color: grey">(1e72a79)</span></li>
<li>doc/fr/kwave-sonagram.png <span style="color: grey">(f57a8f4)</span></li>
<li>doc/fr/kwave-volume.png <span style="color: grey">(372dade)</span></li>
<li>doc/help_cs.po <span style="color: grey">(9b447e7)</span></li>
<li>doc/help_de.po <span style="color: grey">(c7d9957)</span></li>
<li>doc/help_en.docbook <span style="color: grey">(a6b9338)</span></li>
<li>doc/help_es.po <span style="color: grey">(c645cef)</span></li>
<li>doc/help_fr.po <span style="color: grey">(468c1e3)</span></li>
<li>doc/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/krec_record.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-fileinfo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-gui-mdi.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-gui-sdi.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-gui-tab.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-lowpass.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-main.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-memory-setup.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-newfile.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-notch-filter.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-pitch.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-playback-setup.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-record.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-sonagram-setup.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-sonagram.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kwave-volume.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/light_off.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/light_on.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/nonlinear.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/record_new.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/record_pause.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/record_stop.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/signal2digital.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/signed.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/sinus2samples.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/under-construction.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/unsigned.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>po/CMakeLists.txt <span style="color: grey">(d602567)</span></li>
<li>po/cs.po <span style="color: grey">(7ed26a7)</span></li>
<li>po/de.po <span style="color: grey">(474ea8a)</span></li>
<li>po/es.po <span style="color: grey">(34684b5)</span></li>
<li>po/fr.po <span style="color: grey">(770b47e)</span></li>
<li>po/kwave.pot <span style="color: grey">(d7f46f1)</span></li>
<li>doc/en/kwave-main.png <span style="color: grey">(571f68f)</span></li>
<li>doc/en/kwave-gui-tab.png <span style="color: grey">(423c215)</span></li>
<li>doc/en/kwave-lowpass.png <span style="color: grey">(2bfd88f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122245/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>