<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118004/">https://git.reviewboard.kde.org/r/118004/</a>
     </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On May 6th, 2014, 1:03 a.m. CEST, <b>Luigi Toscano</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/118004/diff/1/?file=271626#file271626line110" style="color: black; font-weight: bold; text-decoration: underline;">KF5DocToolsMacros.cmake</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">102</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="nb">_suggest_target_name</span><span class="p">(</span><span class="s">_targ</span><span class="p">)</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">109</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="nb">string</span><span class="p">(</span><span class="s">REPLACE</span> <span class="s2">"/"</span> <span class="s2">"-"</span> <span class="s">_targ</span> <span class="o">${</span><span class="nv">src_doc</span><span class="o">}</span><span class="p">)</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does it work on Windows? (not sure how cmake deals with the different separator there).
Also: the original code was a bit generic (it removed all the non-basic alphanumeric characters); it seems that a non-portable character (over 127) could potentially lead to an invalid target name. Not the case for KF5 stuff, but for 3rd-party, maybe. This is the reference I've found on valid target names; what do you think?
http://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html#tag_04_84_13_03</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good point, I recreated a function to generate a target name, partially based on the old code.</pre>
<br />




<p>- Aurélien</p>


<br />
<p>On May 6th, 2014, 10:56 a.m. CEST, Aurélien Gâteau wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Documentation, KDE Frameworks and Luigi Toscano.</div>
<div>By Aurélien Gâteau.</div>


<p style="color: grey;"><i>Updated May 6, 2014, 10:56 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a big patch made of 4 commits (can provide them separately if needed). This is similar to https://git.reviewboard.kde.org/r/117997/ but for handbook and man pages.

The patch includes a test cmake project which for now must be installed separately because it relies on kdoctools to be already installed. I also refreshed the code a bit, turning macros into functions and using cmake_parse_arguments().</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with supplied test project.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>KF5DocToolsMacros.cmake <span style="color: grey">(51caf34)</span></li>

 <li>tests/kdoctools_install-test/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po-off/es/docs/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po-off/es/docs/kioslave5/fooslave/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po-off/fr/docs/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po-off/fr/docs/man-kjscmd.1.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po/es/docs/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po/es/docs/kioslave5/fooslave/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po/es/docs/man-kjscmd.1.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po/fr/docs/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po/fr/docs/man-kjscmd.1.docbook <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118004/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>