<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118004/">https://git.reviewboard.kde.org/r/118004/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Documentation, KDE Frameworks and Luigi Toscano.</div>
<div>By Aurélien Gâteau.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a big patch made of 4 commits (can provide them separately if needed). This is similar to https://git.reviewboard.kde.org/r/117997/ but for handbook and man pages.

The patch includes a test cmake project which for now must be installed separately because it relies on kdoctools to be already installed. I also refreshed the code a bit, turning macros into functions and using cmake_parse_arguments().</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with supplied test project.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>KF5DocToolsMacros.cmake <span style="color: grey">(51caf34)</span></li>

 <li>tests/kdoctools_install-test/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po-off/es/docs/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po-off/es/docs/kioslave5/fooslave/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po-off/fr/docs/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po-off/fr/docs/man-kjscmd.1.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po/es/docs/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po/es/docs/kioslave5/fooslave/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po/es/docs/man-kjscmd.1.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po/fr/docs/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kdoctools_install-test/po/fr/docs/man-kjscmd.1.docbook <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118004/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>