<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117781/">https://git.reviewboard.kde.org/r/117781/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Documentation and KDE Frameworks.</div>
<div>By Luigi Toscano.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Install again common/, but:
- under a different prefix
- change the structure to allow the installation of the localized common files for other languages. Those files currently live in SVN under trunk/l10n-kde4/<lang>/docs/common but those directories will be removed for kf5 and the content, if any, will be imported here.
This is the combination of four commits which can be checked here:
http://quickgit.kde.org/?p=clones%2Fkdoctools%2Fltoscano%2Fkdoctools-tosky.git&a=log&h=9cd70da7d44147eeb0b119f77bb08e8bb00e87d7
Commit logs (older first):
---
Move the definition of language list to the parent CMakeLists.txt
The list can be then reused (namely by common/)
---
Move "en" common doc files to own directory
---
Install common doc files for all the languages
common/CMakeLists.txt has been completely rewritten; it now supports
a set of language directories and all the files included there.
Right now only en/ is defined, other common files will be added
using the corresponding files from trunk/l10n-kde4/<lang>/docs/common/
(SVN).
---
Enable common/ for a different prefix, adapt kde-chunk.xsl
Common files are installed again as it was in kdelibs4, but under
a different prefix (kdoctools5-common) to avoid conflicts with the
"old" common directory from kdelibs4.
kde-chunk.xsl has been adapted to use this new prefix.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- The files are installed under the common doc prefix
- `kioclient cat help:/konsole/credits.html` shows the usage of the new prefix
- `kioclient cat help:/kdoctools5-common/gpl-license.html` works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>common/artistic-license.html <span style="color: grey">(2069b4e)</span></li>
<li>CMakeLists.txt <span style="color: grey">(3e41a26)</span></li>
<li>common/CMakeLists.txt <span style="color: grey">(4228625)</span></li>
<li>common/block_title_bottom.png <span style="color: grey">(c0c0af5)</span></li>
<li>common/block_title_mid.png <span style="color: grey">(f1ce933)</span></li>
<li>common/block_title_top.png <span style="color: grey">(2344376)</span></li>
<li>common/bsd-license.html <span style="color: grey">(422bb33)</span></li>
<li>common/en/artistic-license.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/block_title_bottom.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/block_title_mid.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/block_title_top.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/bsd-license.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/fdl-license.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/fdl-notice.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/gpl-license.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/kde-default.css <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/kde-docs.css <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/kde_logo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/kde_logo_bg.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/kmenu.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/lgpl-license.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/qpl-license.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/top-kde.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/top-left.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/top-right.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/top.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/x11-license.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/en/xml.dcl <span style="color: grey">(PRE-CREATION)</span></li>
<li>common/fdl-license.html <span style="color: grey">(9ce378a)</span></li>
<li>common/fdl-notice.html <span style="color: grey">(862f09e)</span></li>
<li>common/gpl-license.html <span style="color: grey">(26ae3af)</span></li>
<li>common/kde-default.css <span style="color: grey">(24ef928)</span></li>
<li>common/kde-docs.css <span style="color: grey">(12291a4)</span></li>
<li>common/kde_logo.png <span style="color: grey">(336bfd8)</span></li>
<li>common/kde_logo_bg.png <span style="color: grey">(6cf47f1)</span></li>
<li>common/kmenu.png <span style="color: grey">(ff077c2)</span></li>
<li>common/lgpl-license.html <span style="color: grey">(343576d)</span></li>
<li>common/qpl-license.html <span style="color: grey">(19a863b)</span></li>
<li>common/top-kde.jpg <span style="color: grey">(48967d3)</span></li>
<li>common/top-left.jpg <span style="color: grey">(23c31c7)</span></li>
<li>common/top-right.jpg <span style="color: grey">(22d2a29)</span></li>
<li>common/top.jpg <span style="color: grey">(8be8caa)</span></li>
<li>common/x11-license.html <span style="color: grey">(444a27b)</span></li>
<li>common/xml.dcl <span style="color: grey">(fed2103)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(a2bb02b)</span></li>
<li>src/customization/kde-chunk.xsl <span style="color: grey">(eda3d38)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117781/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>