<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 14, 2014 at 12:57 PM, Burkhard Lück <span dir="ltr"><<a href="mailto:lueck@hube-lueck.de" target="_blank">lueck@hube-lueck.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi,<br>
<br>
I found a lot of docbook issues in many workspace repos, i. e. code but no<br>
corresponding docbook in a repo and vice versa:<br>
<br>
kde-cli-tools:<br>
mv plasma-desktop/doc/kcontrol/filetypes/ kde-cli-tools/doc/kcontrol/filetypes/<br></blockquote><div> </div><div>Are we sure about that? I skimmed through the file and it's describing the KCM module...</div><div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
khelpcenter:<br>
mv doc/* doc/khelpcenter<br>
mv kde-runtime/doc/[onlinehelp|fundamentals|glossary] /doc<br></blockquote><div>Done</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
/plugins/plasma.desktop X-DocPath=help:/plasma-desktop/index.html???<br>
mv plasma-desktop/doc/plasma-desktop/ /doc/<br></blockquote><div>I'm unsure what this means, sorry.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
khotkeys:<br>
mv kde-workspace/doc/kcontrol/khotkeys doc/kcontrol/khotkeys<br></blockquote><div>It's in plasma-desktop/doc/kcontrol/khotkeys</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
kio-extras:<br>
missing docbooks kcontrol/kcmcgi/ + kcontrol/trash/ (from superfluous docbook /doc/kioslave/network/ where is the code?<br></blockquote><div>They are both in Plasma-Desktop, with the rest of KControl modules.</div><div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
kwindowsaddons:<br>
missing docbooks kcontrol/platform/+ kwinshutdown/ ? did we ever had these docbooks?<br></blockquote><div>I don't think so.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
plasma-desktop:<br>
Docbooks, but no corresponding X-DocPath entries<br>
/doc/kcontrol/bookmarks/index.docbook<br>
/doc/kcontrol/cache/index.docbook<br>
/doc/kcontrol/clock/index.docbook<br>
/doc/kcontrol/cookies/index.docbook<br>
/doc/kcontrol/cursortheme/index.docbook<br>
/doc/kcontrol/ebrowsing/index.docbook<br>
/doc/kcontrol/filemanager/index.docbook<br>
/doc/kcontrol/filetypes/index.docbook<br>
/doc/kcontrol/history/index.docbook<br>
/doc/kcontrol/kcm_ssl/index.docbook<br>
/doc/kcontrol/kcmcgi/index.docbook<br>
/doc/kcontrol/kcmcss/index.docbook<br>
/doc/kcontrol/kcmsmserver/index.docbook<br>
/doc/kcontrol/khotkeys/index.docbook<br>
/doc/kcontrol/khtml-adblock/index.docbook<br>
/doc/kcontrol/khtml-behavior/index.docbook<br>
/doc/kcontrol/khtml-general/index.docbook<br>
/doc/kcontrol/khtml-java-js/index.docbook<br>
/doc/kcontrol/khtml-plugins/index.docbook<br>
/doc/kcontrol/netpref/index.docbook<br>
/doc/kcontrol/paths/index.docbook<br>
/doc/kcontrol/performance/index.docbook<br>
/doc/kcontrol/powerdevil/index.docbook<br>
/doc/kcontrol/proxy/index.docbook<br>
/doc/kcontrol/smb/index.docbook<br>
/doc/kcontrol/solid-device-automounter/index.docbook<br>
/doc/kcontrol/splashscreen/index.docbook<br>
/doc/kcontrol/trash/index.docbook<br>
/doc/kcontrol/useragent/index.docbook<br></blockquote><div>So we want the kcm desktop files to link to those?</div><div>For example, there's the clock kcm, which desktop file is in plasma-desktop/kcms/dateandtime/clock.desktop. It doesn't have such X-DocPath but then it doesn't seem to need any move.</div>
<div><br></div><div>Should we add it now? Is it already broken in KDE4?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
plasma-workspace:<br>
missing docbooks: kcontrol/kcmsmserver/ + kcontrol/splashscreen/<br>
mv plasma-desktop/doc/[kcontrol/kcmsmserver|kcontrol/splashscreen]<br>
plasma/workspace/doc/<br></blockquote><div> </div><div>Actually in these cases, kcmsmserver and the ksplashscreen kcm should go to plasma-desktop instead.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
superfluous docbooks /doc/PolicyKit-kde/ where is the code?<br></blockquote><div>I think here: <a href="https://projects.kde.org/projects/extragear/base/polkit-kde-agent-1">https://projects.kde.org/projects/extragear/base/polkit-kde-agent-1</a></div>
<div><br></div><div>I don't know if this has been ported yet, but it should probably go to either frameworksintegration or plasma-workspace.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><font color="#888888"><br>
--<br>
Burkhard Lück<br>
<br>
_______________________________________________<br>
Kde-frameworks-devel mailing list<br>
<a href="mailto:Kde-frameworks-devel@kde.org">Kde-frameworks-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-frameworks-devel" target="_blank">https://mail.kde.org/mailman/listinfo/kde-frameworks-devel</a></font></span></blockquote><div><br></div><div>Thanks for your thorough review! :)</div>
<div><br></div><div>Aleix </div></div></div></div>