<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115744/">https://git.reviewboard.kde.org/r/115744/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is something where the opinion of the kde-windows team is really needed.
The origin of that code traces back to this commit (with a reference https://bugs.kde.org/show_bug.cgi?id=293610):
http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=38b5e7f937b5d2c291c5b20a0c8648632084dde5</pre>
<br />
<p>- Luigi Toscano</p>
<br />
<p>On February 14th, 2014, 12:29 a.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Feb. 14, 2014, 12:29 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The WIN32 part of this if statement doesn't seem to work -> drop it
The frameworks using KDocTools fail otherwise complaining about invalid
paths (Win32 build)
Without this patch I get the following error:
file:///C:/ProgramData/kdoctools5/customization/dtd/kdex.dtd:102: warning:
failed to load external entity
"file:///emerge-root/share/xml/docbook/schema/dtd/4.2/docbookx.dtd"
The path there is actually correct and should work. However, it seems that
XSLT does not accept paths starting with a / on windows. Using / is fine
and evaluates to the root directory of the current drive.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kservice didn't compile before this change, now it does (win32), doesn't affect other platforms</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115744/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>