<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115209/">https://git.reviewboard.kde.org/r/115209/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just please consider the note below, then ship it!</pre>
 <br />







<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/115209/diff/3/?file=243932#file243932line395" style="color: black; font-weight: bold; text-decoration: underline;">src/xslt.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString locateFileInDtdResource(const QString &file)</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">387</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="k"><span class="hl">return</span></span> <span class="n">QStandardPaths</span><span class="o">::</span><span class="n">locate</span><span class="p">(</span><span class="n">QStandardPaths</span><span class="o">::</span><span class="n">GenericDataLocation</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"kdoctools5/"</span><span class="p">)</span> <span class="o">+</span> <span class="n">file</span><span class="p">);</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">390</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n"><span class="hl">QString</span></span><span class="hl"> </span><span class="n"><span class="hl">result</span></span><span class="hl"> </span><span class="o"><span class="hl">=</span></span> <span class="n">QStandardPaths</span><span class="o">::</span><span class="n">locate</span><span class="p">(</span><span class="n">QStandardPaths</span><span class="o">::</span><span class="n">GenericDataLocation</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"kdoctools5/"</span><span class="p">)</span> <span class="o">+</span> <span class="n">file</span><span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As you are here, can you please change this to const QString result = ... ?</pre>
</div>
<br />



<p>- Luigi Toscano</p>


<br />
<p>On February 13th, 2014, 7:56 p.m. UTC, Alexander Richardson wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Documentation, KDE Frameworks and Luigi Toscano.</div>
<div>By Alexander Richardson.</div>


<p style="color: grey;"><i>Updated Feb. 13, 2014, 7:56 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Two separate commits: 

-----------------------------------

Print a message when a file is not found

This way meinproc no longer fails silently

----------------------------------

Allow compiling on Windows with MSVC</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(7d736e9bdded61a9660056d1067690ceed171021)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(5c824941359a68eb8dc54836d05db1fdb217bf6a)</span></li>

 <li>src/meinproc.cpp <span style="color: grey">(7e87370534c3c11ec95e3e45134a7033fcaa475a)</span></li>

 <li>src/meinproc_common.cpp <span style="color: grey">(16234f70e45a703859fce42dcdb2ac1c2fdadade)</span></li>

 <li>src/xslt.cpp <span style="color: grey">(247b49b63ca16072f45c56308d432ecaba47810e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115209/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>