<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115063/">https://git.reviewboard.kde.org/r/115063/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 17th, 2014, 10:46 a.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Scarlett,
Congrats to your first patch (that I see coming by)! I think it's a useful contribution and as far as I can judge, almost good to go in. I've put a comment inline how the explanation could be further improved.
I don't know much about manpages, so I'll let someone else comment on the mechanics.
Thanks for taking care of this.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sebas, you are month too late with "Congrats to your first patch", Scarlett is the kdepim doc maintainer since more than a half year.
@Scarlett: will review later, thanks for waiting</pre>
<br />
<p>- Burkhard</p>
<br />
<p>On January 17th, 2014, 2:52 a.m. UTC, Scarlett Clark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Documentation, KDE Frameworks, Jonathan Riddell, and Sebastian Kügler.</div>
<div>By Scarlett Clark.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2014, 2:52 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While building the package for kubuntu lintian complained about missing manpage for binary. So I created one :) This is my first manpage so be kind. I have no idea how to determine what type eg 1, 7, 8.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> meinproc5 --stylesheet /usr/share/ksgmltools2/customization/kde-include-man.xsl --check man-desktoptojson.8.docbook </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>docs/CMakeLists.txt <span style="color: grey">(86ed60b)</span></li>
<li>docs/desktoptojson/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/desktoptojson/man-desktoptojson.8.docbook <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115063/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>