<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114742/">https://git.reviewboard.kde.org/r/114742/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 31st, 2013, 5:33 p.m. UTC, <b>Thomas Fischer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I got some problems applying this patch. "git apply --check" gives me the following message:
error: unrecognized binary patch at line 8083
error: unrecognized binary patch at line 24735
error: binary patch to 'doc/statistics.png' creates incorrect result (expecting dcf16a3c4f33151eb397636ffde42e45f4230735, got b0f09475b654c686b47b57c30b0d0d2072ef82ca)
error: doc/statistics.png: patch does not apply
The SHA1 sum of the patch file is b09886caa6f1850fdf65263304321ecdc274ae8e. Can someone please check and verify if the patch file is ok or if the problem exists on my end?</pre>
</blockquote>
<p>On December 31st, 2013, 5:48 p.m. UTC, <b>Yuri Chornoivan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works here. Might be a problem with review board... :(
Can I commit by myself into git/master?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">BTW all files of the patch can be downloaded from KDE subversion:
svn co svn://anonsvn.kde.org/home/kde/branches/work/doc/kbibtex
It is enough to remove /man dir and slightly fix CMakeLists.txt (to include /doc).</pre>
<br />
<p>- Yuri</p>
<br />
<p>On December 31st, 2013, 9:33 a.m. UTC, Yuri Chornoivan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Documentation and Thomas Fischer.</div>
<div>By Yuri Chornoivan.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2013, 9:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kbibtex
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A brief documentation including man page (converted from previous untranslatable version).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">EBN, checkXML, compilation, installation. Thomas Fischer did not object to the general concept of the manual when discussing it via email.
PDF version to ease up reviewing is available here:
https://dl.dropboxusercontent.com/u/55247264/kbibtex.pdf</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/svn-update.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/tools-check-spelling.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/view-filter.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>man/CMakeLists.txt <span style="color: grey">(3c5b808)</span></li>
<li>man/kbibtex.1 <span style="color: grey">(ce67b21)</span></li>
<li>doc/list-remove.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/lyx-preferences.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/main-toolbar.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/man-kbibtex.1.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/media-playback-start.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/new-document.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/online-search.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/reference-preview.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/search-results.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/statistics.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/go-up.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/list-add.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/list-of-documents.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/list-of-values.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(194ba74)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/add-macro-source.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/add-macro.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/application-pdf.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/applications-internet.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/code-context.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/config-color.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/config-general.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/config-id-suggestions.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/config-keywords.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/config-pdf.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/config-saving.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/config-user-interface.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/configure.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/cross-ref.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/document-open-remote.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/document-open.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/document-preview.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/document-revert.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/document-save.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/draw-text.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/edit-clear-locationbar-rtl.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/edit-element.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/edit-undo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/element-editor.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/external-tab.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/favorites.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/file-settings.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/filter-toolbar.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/find-pdf.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/first-run.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/flag.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/go-down.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114742/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>